Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(DIALOG): dialog's container-color does not follow Material 3 design specs #30536

Open
1 task
shhdharmen opened this issue Feb 22, 2025 · 0 comments
Open
1 task
Labels
area: material/dialog P2 The issue is important to a large percentage of users, with a workaround

Comments

@shhdharmen
Copy link

shhdharmen commented Feb 22, 2025

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

As per Material 3 guidelines, container-color should use value surface-container-high token, but it's using value surface token.

We can override it by using dialog-overrides mixin like below:

@include mat.dialog-overrides((
  container-color: var(--mat-sys-surface-container-high),
));

But, it should be the default behaviour as per Material 3 specs.

Reproduction

Not needed

Expected Behavior

As per Material 3 guidelines, container-color should use value surface-container-high token.

Actual Behavior

Dialog's container-color is using value surface token.

Environment

  • Angular: 19
  • CDK/Material: 19
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows
@shhdharmen shhdharmen added the needs triage This issue needs to be triaged by the team label Feb 22, 2025
@wagnermaciel wagnermaciel added P2 The issue is important to a large percentage of users, with a workaround area: material/dialog and removed needs triage This issue needs to be triaged by the team labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: material/dialog P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

No branches or pull requests

2 participants