-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement]: Needs to sort the external Iceberg table list #1716
Comments
Sorting by table name can indeed help users find the tables they are interested in more quickly. At the same time, we may also perform this sorting operation on the database list. |
Given that this improvement is very small and meaningful, I suggest opening it up to the new contributors. Therefore, I plan to label it as |
Cause the |
I would like to provide this implementation, but considering that amoro has multiple types of ServerCatalog(iceberg/internal/mix-iceberg/paimon), maybe it would be better to wait for the table-list returned by catalog and sort it uniformly in memory, so that all tables returned by the catalog can be sorted. |
Sorry for the late reply, there seems to be a problem with my email reminder. |
However, According to the response code logic of the rest api |
Then I think we only need to sort the final results of the interface. After all, this only serves the display effect of the table list. |
Search before asking
What would you like to be improved?
Currently, an external Iceberg catalog's table list is returned by the Iceberg catalog's
listTables
method which can not guaranteed order.For example, I have 500 hundred tables named 'mock_table_1' to 'mock_table_500', but the table list in AMS shows like this:
It's not very aesthetically pleasing and inconvenient.
How should we improve?
Sorting it by the lexicographical order of the table names.
Are you willing to submit PR?
Subtasks
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: