Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Avoid releasing external optimizer instances through ams #2315

Closed
3 tasks done
Tracked by #2176
tcodehuber opened this issue Nov 16, 2023 · 1 comment · Fixed by #2319
Closed
3 tasks done
Tracked by #2176

[Improvement]: Avoid releasing external optimizer instances through ams #2315

tcodehuber opened this issue Nov 16, 2023 · 1 comment · Fixed by #2319
Labels
type:improvement

Comments

@tcodehuber
Copy link
Contributor

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Since the lifecycle of external optimizers is controlled by themself, we should not release them from ams frontend. But it's not true from the master branch.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct
@tcodehuber
Copy link
Contributor Author

screenshot-20231116-112605

@tcodehuber tcodehuber changed the title [Improvement]: Avoid users release external optimizer instance through ams [Improvement]: Avoid users release external optimizer instances through ams Nov 16, 2023
@tcodehuber tcodehuber changed the title [Improvement]: Avoid users release external optimizer instances through ams [Improvement]: Avoid the user release external optimizer instances through ams Nov 16, 2023
@tcodehuber tcodehuber changed the title [Improvement]: Avoid the user release external optimizer instances through ams [Improvement]: Avoid releasing external optimizer instances through ams Nov 16, 2023
@tcodehuber tcodehuber mentioned this issue Nov 17, 2023
Merged
3 tasks
@zhoujinsong zhoujinsong mentioned this issue Jun 25, 2024
Closed
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AMORO-2315] Avoid releasing external optimizer instances through ams
1 participant
@tcodehuber