Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Skip the deleted direcotories when cleaning orphan files #2619

Closed
2 tasks done
Tracked by #2176
rfyu opened this issue Mar 9, 2024 · 0 comments · Fixed by #2620
Closed
2 tasks done
Tracked by #2176

[Bug]: Skip the deleted direcotories when cleaning orphan files #2619

rfyu opened this issue Mar 9, 2024 · 0 comments · Fixed by #2620
Labels
type:bug Something isn't working

Comments

@rfyu
Copy link
Contributor

rfyu commented Mar 9, 2024

What happened?

The exception and reasons are explained in #2579 . The only difference is that the current issue occurs in cleaning orphan files.

Affects Versions

master

What engines are you seeing the problem on?

AMS

How to reproduce

No response

Relevant log output

2024-03-05 12:49:29,322 ERROR [async-orphan-files-cleaning-executor-23] [com.netease.arctic.server.table.executor.OrphanFilesCleaningExecutor] [] - hms_ctripdi.dw_ctripdi.c_lp_ahead_show(tableId=8736605) failed to clean orphan file
java.lang.IllegalArgumentException: the target location(hdfs://ns/user/hive/warehouse/dw_ctripdi.db/c_lp_ahead_show/data/d=2023-11-13/meta_id_num_bucket=10) is not directory
        at org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:143) ~[iceberg-bundled-guava-1.4.3.jar:?]
        at com.netease.arctic.io.ArcticHadoopFileIO.isEmptyDirectory(ArcticHadoopFileIO.java:161) ~[amoro-core-0.7.0-SNAPSHOT.jar:?]
        at com.netease.arctic.server.optimizing.maintainer.IcebergTableMaintainer.deleteInvalidFilesInFs(IcebergTableMaintainer.java:480) ~[amoro-ams-server-0.7.0-SNAPSHOT.jar:?]
        at com.netease.arctic.server.optimizing.maintainer.IcebergTableMaintainer.deleteInvalidFilesInFs(IcebergTableMaintainer.java:475) ~[amoro-ams-server-0.7.0-SNAPSHOT.jar:?]
        at com.netease.arctic.server.optimizing.maintainer.IcebergTableMaintainer.clearInternalTableContentsFiles(IcebergTableMaintainer.java:344) ~[amoro-ams-server-0.7.0-SNAPSHOT.jar:?]
        at com.netease.arctic.server.optimizing.maintainer.IcebergTableMaintainer.cleanContentFiles(IcebergTableMaintainer.java:290) ~[amoro-ams-server-0.7.0-SNAPSHOT.jar:?]
        at com.netease.arctic.server.optimizing.maintainer.IcebergTableMaintainer.cleanOrphanFiles(IcebergTableMaintainer.java:123) ~[amoro-ams-server-0.7.0-SNAPSHOT.jar:?]
        at com.netease.arctic.server.table.executor.OrphanFilesCleaningExecutor.execute(OrphanFilesCleaningExecutor.java:61) ~[amoro-ams-server-0.7.0-SNAPSHOT.jar:?]
        at com.netease.arctic.server.table.executor.BaseTableExecutor.executeTask(BaseTableExecutor.java:84) ~[amoro-ams-server-0.7.0-SNAPSHOT.jar:?]
        at com.netease.arctic.server.table.executor.BaseTableExecutor.lambda$null$2(BaseTableExecutor.java:74) ~[amoro-ams-server-0.7.0-SNAPSHOT.jar:?]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_291]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_291]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [?:1.8.0_291]
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [?:1.8.0_291]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_291]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_291]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_291]

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant