[AMORO-3440] Implement the refresh and exploration of OptimizingGroup… #3457
+156
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3457 +/- ##
============================================
+ Coverage 21.59% 21.74% +0.15%
- Complexity 2353 2386 +33
============================================
Files 431 431
Lines 40347 40476 +129
Branches 5711 5741 +30
============================================
+ Hits 8712 8801 +89
- Misses 30903 30929 +26
- Partials 732 746 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mansonliwh
force-pushed
the
optimizing-config
branch
3 times, most recently
from
54ff948 to
9c3fd97
Compare
mansonliwh
changed the title
zhoujinsong
reviewed
Mar 12, 2025
amoro-ams/src/main/java/org/apache/amoro/server/resource/DefaultOptimizerManager.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/resource/DefaultOptimizerManager.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/resource/DefaultOptimizerManager.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java
Show resolved
Hide resolved
github-actions
bot
added
type:docs
baiyangtx
reviewed
Mar 13, 2025
amoro-ams/src/main/java/org/apache/amoro/server/persistence/mapper/TableMetaMapper.java
Outdated
Show resolved
Hide resolved
| @@ -380,6 +380,12 @@ public class AmoroManagementConf { | |||
| .defaultValue(Duration.ofSeconds(3)) | |||
| .withDescription("Optimizer polling task timeout."); | |||
|
|
|||
| public static final ConfigOption<Duration> OPTIMIZER_QUEUE_REFRESH_INTERVAL = | |||
| ConfigOptions.key("optimizer.queue-refresh-interval") | |||
There was a problem hiding this comment.
Suggested change
| ConfigOptions.key("optimizer.queue-refresh-interval") | |
| ConfigOptions.key("optimizing-service.refresh-group-interval") |
There was a problem hiding this comment.
The name self-optimizing.refresh-group-interval seems appropriate, especially since we already have some configurations prefixed with self-optimizing.
There was a problem hiding this comment.
Besides, can you help to add this new configuration example to the configuration temp file.
mansonliwh
force-pushed
the
optimizing-config
branch
2 times, most recently
from
5a28c69 to
e63e960
Compare
mansonliwh
force-pushed
the
optimizing-config
branch
from
e63e960 to
01931b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3440 .
Brief change log
The OptimizingService and OptimizerManager have been decoupled: the OptimizerManager handles metadata persistence and modifications, while the OptimizingService includes a watcher to synchronize the in-memory OptimizingQueue map with persisted data.
This allows the master node to run the OptimizingService while other nodes modify metadata via a web interface, ensuring the master stays updated.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation