Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the DataFileWriterBuilder tests #726

Closed
Fokko opened this issue Nov 27, 2024 · 2 comments · Fixed by #768
Closed

Extend the DataFileWriterBuilder tests #726

Fokko opened this issue Nov 27, 2024 · 2 comments · Fixed by #768
Assignees
@jonathanc-n
Labels
good first issue Good for newcomers

Comments

@Fokko
Copy link
Contributor

Fokko commented Nov 27, 2024 •
edited
Loading

In data_file_writer we write out a schema but don't have any tests for that. I think it would be good to write out a schema to validate that the field-IDs are there (they are, I checked by hand). And also add a test where we write DataFile that has a partition.
@Fokko Fokko added the good first issue Good for newcomers label Nov 27, 2024
@Fokko Fokko mentioned this issue Nov 27, 2024
Open
28 tasks
@jonathanc-n
Copy link
Contributor

@Fokko I would like to try working on this, may I be assigned this?

@liurenjie1024
Copy link
Contributor

@Fokko I would like to try working on this, may I be assigned this?

@jonathanc-n Welcome to contribute!

@jonathanc-n jonathanc-n mentioned this issue Dec 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanc-n jonathanc-n

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add DataFileWriter tests for schema and partition jonathanc-n/iceberg-rust
3 participants
@Fokko @liurenjie1024 @jonathanc-n