Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent app.kubernetes.io/part-of label for operator-managed resources #1689

Open
aali309 opened this issue Mar 11, 2025 · 0 comments · May be fixed by #1686
Open

Consistent app.kubernetes.io/part-of label for operator-managed resources #1689

aali309 opened this issue Mar 11, 2025 · 0 comments · May be fixed by #1686

Comments

@aali309
Copy link
Contributor

aali309 commented Mar 11, 2025

Operator adds app.kubernetes.io/part-of: argocd label on all it's managed resources. However for appset resources this label value is argocd-applicationset and not argocd. Not sure about the reason but the upstream uses argocd for this label in appset resources so we should follow the same in operator.

To Reproduce:

  • Create a ArgoCD CR and enable applicationset

  • Check the labels on applicationset resources like serviceaccount, roles, rolebinding

  • Also enable other components and check for the app.kubernetes.io/part-of label on it's resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant