Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove archived dependency: github.com/mitchellh/go-homedir #1923

Open
mihaitodor opened this issue Feb 8, 2025 · 2 comments

Comments

@mihaitodor
Copy link

Is your feature request related to a problem? Please describe

First of all, thank you for taking the time to rewrite this project in Go!

I noticed that github.com/mitchellh/go-homedir is used here and here to load the config and the env config, but this project has been archived by the maintainer and it might be worth migrating away from it.

Describe the proposed solution

Deprecate and remove the usage of github.com/mitchellh/go-homedir.

Describe similar asdf features and why they are not sufficient

N/A

Describe other workarounds you've considered

N/A

@Stratus3D
Copy link
Member

Contributions welcome here!

@endorama
Copy link

What would be the accepted path forward here? I see some options:

  1. Copy the code in an internal package in this repo
  2. Find an alternative third party library
  3. Keep using it

The library itself is pretty simple and can be reviewed for an effective risk of compromise (dependencies and review for current code). As is archived as long as it compiles with the new Go versions there may not be a need to remove it.

Alternatively I think moving the code and test in an internal package would be a simple, effective and practical solution: that code is not going to require much maintenance given the reduced scope.

What do you think? Happy to provide a PR once we agree on a path forward ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants