Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add [homebrew] cask download badge #10595

Merged
merged 6 commits into from
Oct 12, 2024
Merged

add [homebrew] cask download badge #10595

merged 6 commits into from
Oct 12, 2024

Conversation

tapaj
Copy link
Contributor

@tapaj tapaj commented Oct 10, 2024

@tapaj tapaj force-pushed the features/homebrew-cask-download branch from cf93192 to 581cc6f Compare October 10, 2024 16:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @tapaj!

Generated by 🚫 dangerJS against f8a414e

jNullj
jNullj approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@jNullj jNullj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed LGTM

Also run in docker and seems to work. Could not run tests (due to local issue), but PR workflow should take care of that.

image
image

@jNullj
Copy link
Member

jNullj commented Oct 11, 2024

After merge we need to remember to update the docs

@chris48s chris48s added the service-badge New or updated service badge label Oct 12, 2024
@chris48s
Copy link
Member

Thanks, and thanks for reveiwing @jNullj 👍
I've just pushed a quick commit to this branch tidying up the cask/formula terminology

@chris48s chris48s enabled auto-merge October 12, 2024 12:00
@chris48s chris48s added this pull request to the merge queue Oct 12, 2024
Merged via the queue into badges:master with commit 8ed3dc8 Oct 12, 2024
23 checks passed
@chris48s chris48s mentioned this pull request Oct 12, 2024
Closed
@tapaj tapaj deleted the features/homebrew-cask-download branch October 17, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

@jNullj jNullj jNullj approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tapaj @jNullj @chris48s