remove prefix v for commit hash version #10597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some services might return version as a commit hash like aur. it makes no sense to prefix v before the commit. Fixes badges#10591
add both full commit hash and short commit hash tests to addv. expected result - no v prefix.
jNullj
added
core
chris48s
reviewed
Oct 12, 2024
| @@ -127,11 +127,12 @@ function omitv(version) { | |||
| return version | |||
| } | |||
|
|
|||
| const ignoredVersionPatterns = /^[^0-9]|[0-9]{4}-[0-9]{2}-[0-9]{2}/ | |||
| const ignoredVersionPatterns = | |||
| /^[^0-9]|[0-9]{4}-[0-9]{2}-[0-9]{2}|^[a-f0-9]{7,40}$/ | |||
There was a problem hiding this comment.
I was also thinking about how to deal with short/long hashes
I like this approach 👍
chris48s
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore commit hash in addv
Fixes #10591 - see issue for more info