Add [Terraform] registry providers and modules downloads #10793
Conversation
|
|
🚀 Updated review app: https://pr-10793-badges-shields.fly.dev |
| static category = 'downloads' | ||
|
|
||
| static route = { | ||
| base: 'terraform/module/downloads', |
There was a problem hiding this comment.
If you have a look over all the other downloads badges, we just use serviceName/:interval(dw|dm|dy)... or whatever. We can remove the /downloads part from the route base here.
| static category = 'downloads' | ||
|
|
||
| static route = { | ||
| base: 'terraform/provider/downloads', |
services/terraform/terraform-base.js
Outdated
| id: Joi.string().required(), | ||
| type: Joi.string().required(), |
There was a problem hiding this comment.
Looks like we don't actually use the id or type values.
If so, we can remove these two from the schema. We don't need to validate values we don't use: We should only fail if values we actually rely on to render the badge are missing from the response or don't match the expected format.
|
One of the things it says on https://developer.hashicorp.com/terraform/registry/api-docs#http-status-codes is
but I can't find the actual rate limits (as in how many request per minute/hour/whatever we are allowed to make) explicitly stated. Do you have any idea what kind of rate limit we're trying to stay under? For a rate limited service where we just show a number of downloads (in this case, up to date/precise number is not super important), how about we set the badge images to be cached downstream for an hour with |
arnaud-dezandee
force-pushed
the
feat/terraform-downloads
branch
from
e92406e to
d5b9a27
Compare
|
Hi @chris48s, I agreed with all your comments and made the necessary adjustments 👍 |
|
🚀 Updated review app: https://pr-10793-badges-shields.fly.dev |
Hi!
This PR adds Terraform Registry downloads summary support for:
It uses public API endpoints as documented here