Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed [reddit] Negative Karma Issue #6992

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

sahrohit
Copy link
Contributor

@sahrohit sahrohit commented Sep 7, 2021

The API schema validation made the obviously wrong assumption that karma values would be 0 or more, resulting in "Invalid Data Response" for users with negative karma points. The type is changed from nonNegativeInteger to anyInteger, as indicated in the issue.

@shields-ci
Copy link

Warnings
⚠️ This PR modified service code for reddit but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @sahrohit!

Generated by 🚫 dangerJS against 4760254

@chris48s chris48s changed the title Fixed Reddit Negative Karma Issue Fixed [reddit] Negative Karma Issue Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants