Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [Testspace] with new "untested" value in case_counts array #8544

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Fix [Testspace] with new "untested" value in case_counts array #8544

merged 1 commit into from
Oct 18, 2022

Conversation

Aldaviva
Copy link
Contributor

Hello,

I noticed that all Testspace badges started returning "invalid response data" recently. The cause was a recent change in the response object of the Testspace web API: the case_counts array in the Results object now has length 5 instead of 4. A new integer was appended to the end which represents the number of untested tests, which are manual tests that have not been run yet.

Live example Screenshot for posterity
Testspace tests tests: invalid response data

The API docs haven't been updated yet as of 2022-10-17, but I contacted the Testspace developers and figured out what the new value means.

To fix the invalid error, this change updates the schema for the Testspace API response with the new array length. It also adds a new metric parameter value (untested) to the TestspaceTestCount service and includes it in the internal object returned by TestspaceBase.transformCaseCounts(), as well adding it to the total value in that object. The documentation URLs have also changed.

I didn't add untested to the TestspacePassRatio or TestspaceTests services, since those already didn't use skipped and errored, respectively, and it didn't seem like it would make sense to start including untested manual cases there.

I think I've covered all the requirements for contributing, but let me know if I missed anything or if any other changes need to be made.

Thanks!

@shields-ci
Copy link

Messages
📖 ✨ Thanks for your contribution to Shields, @Aldaviva!

Generated by 🚫 dangerJS against b05feb7

@chris48s chris48s added service-badge New or updated service badge keep-service-tests-green Related to fixing failing tests of the services labels Oct 18, 2022
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers. I'd spotted this was failing on the nightly service tests runs but I hadn't had a chance to dig into it yet.

@chris48s chris48s merged commit eea9bbd into badges:master Oct 18, 2022
@Aldaviva Aldaviva deleted the testspace-untested branch October 18, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-service-tests-green Related to fixing failing tests of the services service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants