Fix [Testspace] with new "untested" value in case_counts array #8544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that all Testspace badges started returning "invalid response data" recently. The cause was a recent change in the response object of the Testspace web API: the
case_counts
array in the Results object now has length 5 instead of 4. A new integer was appended to the end which represents the number of untested tests, which are manual tests that have not been run yet.The API docs haven't been updated yet as of 2022-10-17, but I contacted the Testspace developers and figured out what the new value means.
To fix the invalid error, this change updates the schema for the Testspace API response with the new array length. It also adds a new
metric
parameter value (untested
) to theTestspaceTestCount
service and includes it in the internal object returned byTestspaceBase.transformCaseCounts()
, as well adding it to thetotal
value in that object. The documentation URLs have also changed.I didn't add
untested
to theTestspacePassRatio
orTestspaceTests
services, since those already didn't useskipped
anderrored
, respectively, and it didn't seem like it would make sense to start including untested manual cases there.I think I've covered all the requirements for contributing, but let me know if I missed anything or if any other changes need to be made.
Thanks!