[VisualStudioMarketplace] Add support to prerelease extensions version (Issue #8207) #8561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d pre-release example
… comment to explain the flags property calculations
…to match new logic
OronW
changed the title
chris48s
reviewed
Oct 24, 2022
| const { extension } = this.transformExtension({ json }) | ||
| const version = extension.versions[0].version | ||
| const preRelease = 'Microsoft.VisualStudio.Code.PreRelease' |
There was a problem hiding this comment.
I think the intent here would be a bit clearer if we called this var preReleaseKey or preReleaseTag
Comment on lines
47
to
52
| const version = includePrereleases | ||
| ? extension.versions[0].version | ||
| : extension.versions.find( | ||
| obj => !obj.properties.find(({ key }) => key === preRelease) | ||
| ).version | ||
|
|
There was a problem hiding this comment.
There are a couple of problems here.
- If there are only pre-releases and no stable releases this will fail because
.find()will just returnundefined. For this case, we should fall back to showing the latest pre-release if there are no stable releases at all (this is what we normally do for other badges). - This one is a bit more of an edge case: It looks like the deal is pre-releases are indicated by
{"key": "Microsoft.VisualStudio.Code.PreRelease", "value": "true"}and stable releases are indicated by complete absence of that object, but I think if we were to encounter a release with{"key": "Microsoft.VisualStudio.Code.PreRelease", "value": "false"}we should also consider that stable (whether or not we currently think this is likely). This code would classify that as a pre-release.
There was a problem hiding this comment.
Thanks for your comments.
I've changed the logic a bit so there will not be duplicated code:
- I've created a new logic which implements a fallback option.
- I now verify the value and not just the presence of the key.
chris48s
changed the title
|
Minor point: I've edited the PR title so it will run the tests for the whole VSCode Marketplace service family on the next push. This PR modifies the |
…elease key value is 'true'
…prerelease key has false value
|
@chris48s I've updated my code accordingly, and I've added 2 more tests -
I've also run the entire VisualStudioMarketplace tests locally without issues. Please let me know if there's anything else :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pre-release version support to VScode marketplace service.
Updated response schema.
Updated Tests to include pre-release version.
PR fixing issue #8207