Add [Coincap] Cryptocurrency badges

[alexandresanlim]

Added

• Symbol
• Rank
• Price
• Change Percent on 24hr

[shields-ci]

	Messages
📖	✨ Thanks for your contribution to Shields, @alexandresanlim!

Generated by 🚫 dangerJS against 8bd2c24

[chris48s]

This is in pretty good shape. It is clear you have read the contributing docs and thanks for including tests.

[chris48s]

For the tests that call a live service, we sholdn't hard-code a response in the test. Lets validate that this as Joi.number().integer().min(1).required()

[alexandresanlim]

The .json return a string even being number, i had to validated it with regex.

[chris48s]

You can still use Joi.number() to picture-check a string.

Try this as a minimal example:

import Joi from 'joi'

const schema = Joi.number().integer().min(1).required()

Joi.attempt('1', schema); // passes
Joi.attempt('0', schema); // fails

Same goes for the changepercent24hr and priceusd schemas - they can use Joi.number() instead of a regex which should make things a bit neater.

[alexandresanlim]

Nice! but to changepercent24hr and priceusd Joi.number().required() doesn't worked.

const schema = Joi.object({
  data: Joi.object({
    changePercent24Hr: Joi.number().required(),
    name: Joi.string().required(),
  }).required(),
}).required()

[chris48s]

Looking at the build for this branch it is failing with
ValidationError: message mismatch: "value" does not match any of the allowed types
because at the time the tests ran the change was negative and the validator isn't expecting a leading -.
We'll need to adjust the validator to allow negative values.

[alexandresanlim]

I have added negative possibilities on test-validators.js ok?

[chris48s]

I spotted one more issue on the last check. The examples were rendering with label undefined. Merging with a fix for that