Add Support for [Nostr] Followers

[sepehr-safari]

Added first and simplest interaction with Nostr (https://github.com/nostr-protocol/nostr).

Using APIs from https://api.nostr.band/ to keep things fast and simple.

Some other useful stats will be added further.

[github-actions]

	Messages
📖	✨ Thanks for your contribution to Shields, @sepehr-safari!

Generated by 🚫 dangerJS against 4e63e9f

[sepehr-safari]

ready to merge I guess?

[chris48s]

Before I do a code review on this, a couple of things:

1. As I understand it, nostr is a decentralised protocol. https://nostr.band/ is a stats service, but it is basically a stats service someone has set up - it is not "official". Someone else could come along and set up another "stats about nostr" service which is no more or less valid as a source of information than nostr.band. Is that a reasonable assessment of what nostr.band is?

2. Your service tests are failing. Can you have a look at getting the build passing before we review.

Thanks

[sepehr-safari]

nostr is a decentralised protocol.

Yes.

https://nostr.band/ is a stats service.

Yes.

https://nostr.band/ is not "official".

Yes.

Someone else could come along and set up another "stats about nostr" service.

Yes.

Your service tests are failing.

FIXED! (3e896e4)

so here is the conclusion:

1. there is NOTHING "official" about Nostr. not even a little thing. this is the first rule of "decentralize".
2. we can simply rely on a well-stablished service such as nostr.band.

ready to code review and merge.
thank you.

[chris48s]

So I think I'd say the "service" here isn't really "nostr". It is nostr.band.

I guess what I'm getting at here is: If someone else sets up a competing service offering stats about the nostr network, why did stats from nostr.band get to be /nostr and not them? Seems like no good reason, right?

I'd suggest we make the route base for this /nostr-band.

A somewhat analogous situation would be: We have badges that show stats about the NPM ecosystem from https://npms.io/ and https://npm-stat.com/ but they live under /npm-stat and /npms-io.

[sepehr-safari]

you are right. I've changed the service from nostr to nostr-band.
is there anything else that should be considered for this pr?

I would also suggest creating a separate service for nostr where users can freely choose their desired relay and fetch stats directly from that relay over websocket.
that would be the real decentralized nostr flow, not forcing users to use a pre-defined API service.
is there any documentation to use websocket inside your services?

[github-actions]

🚀 Updated review app: https://pr-9870-badges-shields.fly.dev

[chris48s]

thanks - have looked over the code and left some comments

[chris48s]

I would also suggest creating a separate service for nostr where users can freely choose their desired relay and fetch stats directly from that relay over websocket.
that would be the real decentralized nostr flow, not forcing users to use a pre-defined API service.
is there any documentation to use websocket inside your services?

I suggest moving the discussion of this to a badge request issue. Lets not scope creep here as it feels like what you've got here is pretty close.

We don't have any other services that use websockets, so if you wanted to contribute that it would have to be a new base class. If you wanted to implement that, I'd suggest looking over the existing base classes we have, for example:

• https://github.com/badges/shields/blob/master/core/base-service/base-graphql.js
• https://github.com/badges/shields/blob/master/core/base-service/base-json.js
• https://github.com/badges/shields/blob/master/core/base-service/base-xml.js

but its probably useful to nail down the details in an issue a bit first given it would be quite an involved contribution.

[sepehr-safari]

thanks for your detailed review. think I've successfully addressed all your specs.

[sepehr-safari]

I suggest moving the discussion of this to a badge request issue.

good idea. I will open an issue for implementing websocket and the rest.

[github-actions]

🚀 Updated review app: https://pr-9870-badges-shields.fly.dev

[chris48s]

Nice one. Merging. Btw, I really appreciate the way you replied to each comment with a link to the commit addressing that comment - makes the second pass of review super easy. Thanks

[sepehr-safari]

I really appreciate the way you replied to each comment with a link to the commit addressing that comment - makes the second pass of review super easy.

glad it was helpful. thank you.