Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Dark mode not working in login page #91

Open
abansal15 opened this issue Jul 14, 2023 · 15 comments · May be fixed by #97
Open

[BUG]: Dark mode not working in login page #91

abansal15 opened this issue Jul 14, 2023 · 15 comments · May be fixed by #97
Labels
bug Something isn't working

Comments

@abansal15
Copy link
Contributor

Describe the bug

image

Steps To Reproduce

No response

Expected Behavior

in dark mode the form of login should turn to black

Screenshots/Videos

No response

What device are you using?

No response

Operating System

No response

What browsers are you seeing the problem on?

No response

Additional context

No response
@abansal15 abansal15 added the bug Something isn't working label Jul 14, 2023
@abansal15
Copy link
Contributor Author

please assign this issue to me

@sambhavgupta0705
Copy link
Collaborator

sambhavgupta0705 commented Jul 14, 2023 •
edited
Loading

@abansal15 first provide a design here then we will think about this.

@abansal15
Copy link
Contributor Author

The whole white box of the login section should have it's background black when dark mode is toggled and text should be white. Is it ok @sambhavgupta0705

@sambhavgupta0705
Copy link
Collaborator

first show me a design

@abansal15
Copy link
Contributor Author

abansal15 commented Jul 15, 2023 •
edited
Loading

design in dark mode :
image
design in light mode :
image

@sambhavgupta0705

@abansal15
Copy link
Contributor Author

@sambhavgupta0705 is the page now looking good?

@JawHawk
Copy link

JawHawk commented Jul 16, 2023

@abansal15
image
Even change input backgrounds and text color.

@abansal15
Copy link
Contributor Author

@JawHawk done the changes

image

now is it ok ?

@abansal15
Copy link
Contributor Author

@JawHawk ?

@sambhavgupta0705
Copy link
Collaborator

@abansal15 share the full screen preview

@abansal15
Copy link
Contributor Author

abansal15 commented Jul 18, 2023 •
edited
Loading

image
in dark mode

@abansal15
Copy link
Contributor Author

image
in light mode

@sambhavgupta0705
Copy link
Collaborator

@abansal15 don't change the background image for login page in light mode

@abansal15
Copy link
Contributor Author

ok i will change the background image to older one in the light mode

@abansal15
Copy link
Contributor Author

in dark mode
image
in light mode
image

@abansal15 abansal15 linked a pull request Jul 18, 2023 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the dark mode functional in login page of issue #91 abansal15/resource-sharing
3 participants
@sambhavgupta0705 @JawHawk @abansal15