Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual raw line for ParserBot.recover_csv #1011

Closed
ghost opened this issue Jun 19, 2017 · 4 comments
Closed

Use actual raw line for ParserBot.recover_csv #1011

ghost opened this issue Jun 19, 2017 · 4 comments
Labels
component: core feature Indicates new feature requests or new features
Milestone

Comments

@ghost
Copy link

ghost commented Jun 19, 2017

@chorsley has a neat solution: https://github.com/chorsley/intelmq/blob/962d630bd2a3eb7991f905d5ab795835ff1e9725/intelmq/bots/parsers/zoneh/parser.py#L15

This way we do not need to reconstruct the raw line.

@ghost ghost added component: core feature Indicates new feature requests or new features labels Jun 19, 2017
@ghost ghost added this to the v1.1 Feature release milestone Jun 19, 2017
@chorsley
Copy link
Collaborator

This code has been submitted in lib/bot.py via #1015.

@ghost
Copy link
Author

ghost commented Jul 3, 2017

@chorsley This adds the code to the zoneh parser, not to the common functions.

@chorsley
Copy link
Collaborator

chorsley commented Jul 4, 2017

@wagner-certat given current time constraints, I'll need to come back to that later, unless someone beats me to it.

@ghost
Copy link
Author

ghost commented Jul 4, 2017

I'll move the code to the proper place in lib/ once the PR is merged. That involves many other adaptions too.

@ghost ghost modified the milestones: 1.1.0, 1.2.0 Jun 28, 2018
@ghost ghost closed this as completed in d80c3fe Aug 7, 2018
@ghost ghost modified the milestones: 1.2.0, 2.0.0 Apr 9, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core feature Indicates new feature requests or new features
Projects
None yet
Development

No branches or pull requests

1 participant