Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message sanitation for IPAddresses does not call generic sanitizer #1219

Closed
ghost opened this issue Mar 19, 2018 · 0 comments
Closed

Message sanitation for IPAddresses does not call generic sanitizer #1219

ghost opened this issue Mar 19, 2018 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Milestone
1.0.4

Comments

@ghost
Copy link

ghost commented Mar 19, 2018

For example:

>>> ip = ' 2a03:f80:ed15:ca7:ea75:b12d:6bb:7a'  # note the leading space
>>> harm.IPAddress.sanitize(ip)

(gives None = fail)

the reason: the sanitation of Generic Type is only called in is_valid with sanitize=True, but not in the sanitize method itself.
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: core labels Mar 19, 2018
@ghost ghost added this to the 1.0.4 milestone Mar 19, 2018
@ghost ghost self-assigned this Mar 19, 2018
@ghost ghost closed this as completed in dd4efc2 Mar 19, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Projects
None yet
Milestone
1.0.4
Development

No branches or pull requests
0 participants