Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent message counter log messages for all kind of bots #1278

Open
ghost opened this issue Jul 20, 2018 · 2 comments
Open

Consistent message counter log messages for all kind of bots #1278

ghost opened this issue Jul 20, 2018 · 2 comments
Labels
bug Indicates an unexpected problem or unintended behavior component: core help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@ghost
Copy link

ghost commented Jul 20, 2018

While we have the "Processed ... messages since last logging" for all other bot types, the output does not have this message for outputs.

The reason is that the counter is handled in the send-message method, which is never called by outputs. This raises the question where we actually should do this, probably directly after the process() if it succeeded?

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: core labels Jul 20, 2018
@ghost ghost added this to the 1.1.1 milestone Jul 20, 2018
@ghost ghost modified the milestones: 1.1.1, 1.2.0 Oct 16, 2018
@ghost ghost changed the title No processed message counter for outputs Consistent message counter log messages for all kind of bots Oct 16, 2018
@ghost
Copy link
Author

ghost commented Oct 16, 2018

Proposal:

For collectors: Sent 1 messages since last logging.
For parsers: Received 1 messages, sent 1 messages, found 0 errors since last logging.
For experts: Received 1 messages, sent 1 messages since last logging.
For outputs: Received 1 messages since last logging.

Currently, the logging of the Sent 2 events and found 0 error(s). works differently than the other ones and is not configurable. It should be consistent for all kinds of bots.

@ghost ghost modified the milestones: 1.2.0, 1.1.1 Oct 16, 2018
@ghost
Copy link
Author

ghost commented Oct 19, 2018

changing the milestone to 1.2 as this will change existing log messages

probably solve together with #1274

@ghost ghost modified the milestones: 1.1.1, 1.2.0 Oct 19, 2018
@ghost ghost modified the milestones: 1.2.0, 2.0.0 Apr 9, 2019
@ghost ghost modified the milestones: 2.0.0, 2.1.0 May 14, 2019
@ghost ghost modified the milestones: 2.1.0, 2.2.0 Oct 25, 2019
@ghost ghost modified the milestones: 2.2.0, 2.3.0 Jun 17, 2020
@ghost ghost removed this from the 2.3.0 milestone Feb 4, 2021
@sebix sebix added the help wanted Indicates that a maintainer wants help on an issue or pull request label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: core help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Development

No branches or pull requests

1 participant