Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping bots with error procedure pass and pipeline errors #1333

Closed
ghost opened this issue Oct 10, 2018 · 2 comments
Closed

Stopping bots with error procedure pass and pipeline errors #1333

ghost opened this issue Oct 10, 2018 · 2 comments
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Milestone

Comments

@ghost
Copy link

ghost commented Oct 10, 2018

Reported via intelmq-users

https://github.com/certtools/intelmq/blob/1.1.0/intelmq/lib/bot.py#L258

                        # error_procedure: pass and pipeline problem
                        else:
                            self.stop()

Should be revisited.

quoting myself: https://lists.cert.at/pipermail/intelmq-users/2018-October/000074.html

If the error_procedure
is pass and there are pipeline problems, the bot stops (in bot.py search
for "error_procedure: pass and pipeline problem"). AFAIR the reasoning
for this was/is that if the bot would not stop, the pipeline would be
kind of DOS'ed. But as problems with memory and snapshots in redis are
handled better now, that could be relaxed.

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: core labels Oct 10, 2018
@ghost ghost added this to the 1.1.1 milestone Oct 10, 2018
@ghost ghost self-assigned this Oct 10, 2018
@ghost
Copy link
Author

ghost commented Oct 23, 2018

@ghost
Copy link
Author

ghost commented Nov 8, 2018

Output: retry forever.

@ghost ghost closed this as completed in ad442ca Nov 8, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Projects
None yet
Development

No branches or pull requests

0 participants