Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url2fqdn missing ip #1416

Closed
kalyparker opened this issue Jun 10, 2019 · 4 comments
Closed

Url2fqdn missing ip #1416

kalyparker opened this issue Jun 10, 2019 · 4 comments
Labels
bug Indicates an unexpected problem or unintended behavior component: bots feature Indicates new feature requests or new features
Milestone

Comments

@kalyparker
Copy link
Contributor

Hi everyone,
Bot url2fqdn is ideal for parsing url.
Problem is if the hostname is an IP, this information is not parse.
Is it a good idea to add this information in this bot or should I recreate another bot ?
Thx

@kalyparker kalyparker changed the title Url2fqdn Url2fqdn missing ip Jun 10, 2019
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots feature Indicates new feature requests or new features labels Jun 12, 2019
@ghost
Copy link

ghost commented Jun 12, 2019

Hi,

I see the problem. Thanks for raising this issue.

For the new bot: I don't see a good reason for it, because it is the same functionality, extracting the host from the URL. With the proposed addition, the host can then also be an IP address and the name does not match anymore (URL to Host maybe?)

@ghost ghost added this to the 2.1.0 milestone Jun 12, 2019
@kalyparker
Copy link
Contributor Author

ok, so basically change the name and push it on which version ?

@kalyparker
Copy link
Contributor Author

On which branch should I push this modification?
On develop or on develop-2.0?
Should I need to modify other files (example, tests?)

@ghost
Copy link

ghost commented Jul 30, 2019

Hi,

I can also take care about the proposed(!) name change myself, as this needs backwards compatibility too.

If you want to work on this bug, ideally on the base of the maintenance branch. If it is develop, then I can also backport it too.
Thanks for the reminder about the develop-2.0 branch, I will have a look if we can remove that one.

@ghost ghost modified the milestones: 2.1.0, 2.0.1 Jul 30, 2019
@ghost ghost closed this as completed in a739866 Aug 21, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots feature Indicates new feature requests or new features
Projects
None yet
Development

No branches or pull requests

1 participant