Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowserver parser: Bad error message if report name is unknown #1507

Closed
ghost opened this issue Feb 20, 2020 · 0 comments
Closed

Shadowserver parser: Bad error message if report name is unknown #1507

ghost opened this issue Feb 20, 2020 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior component: bots usability
Milestone

Comments

@ghost
Copy link

ghost commented Feb 20, 2020

If the report has not file name then this exception occurs:

Bot has found a problem.
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/intelmq/lib/bot.py", line 267, in start
    self.process()
  File "/usr/local/lib/python3.6/dist-packages/intelmq/lib/bot.py", line 942, in process
    for line in self.parse(report):
  File "/usr/local/lib/python3.6/dist-packages/intelmq/bots/parsers/shadowserver/parser.py", line 65, in parse
    filename_search = self.__is_filename_regex.search(self.report_name)
TypeError: expected string or bytes-like object

Should be a human readable error message.

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots usability labels Feb 20, 2020
@ghost ghost added this to the 2.1.3 milestone Feb 20, 2020
@ghost ghost self-assigned this Mar 26, 2020
@ghost ghost closed this as completed in 260b94d Mar 26, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots usability
Projects
None yet
Development

No branches or pull requests

0 participants