Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cymru-whois bot returning registry 'OTHER' for 6to4 IPv6 address #996

Closed
haam3r opened this issue Jun 6, 2017 · 5 comments
Closed

Cymru-whois bot returning registry 'OTHER' for 6to4 IPv6 address #996

haam3r opened this issue Jun 6, 2017 · 5 comments
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Milestone

Comments

@haam3r
Copy link

haam3r commented Jun 6, 2017

So I'm seeing things like this:

intelmq.lib.exceptions.InvalidValue: invalid value 'OTHER' (<class 'str'>) for key 'source.registry' is_valid returned False.
2017-06-06 03:43:20,871 - cymru-whois-expert - INFO - Current Message(event): {'source.network': '2002::/16', 'classification.type': 'b
lacklist', 'source.asn': 6939, 'feed.url': 'https://lists.blocklist.de/lists/all.txt', 'feed.accuracy': 100.0, 'time.observation': '201
7-06-05T18:52:38+00:00', 'source.ip': '2002:d06e:4282::d06e:4282', 'feed.provider': 'blocklist.de', 'feed.name': 'blocklist', 'raw': 'M
jAwMjpkMDZlOjQyODI6MDAwMDowMDAwOjAwMDA6ZDA2ZTo0Mjgy', 'source.as_name': 'HURRICANE - Hurricane Electric, Inc., US', 'classification.tax
onomy': 'other'}.

What should be the correct way to handle this?

@ghost ghost added this to the v1.0 Stable Release milestone Jun 6, 2017
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots labels Jun 6, 2017
@ghost
Copy link

ghost commented Jun 6, 2017

IMHO we should (explicitly) ignore that

@haam3r
Copy link
Author

haam3r commented Jun 6, 2017

I'm currently using a very dirty workaround of adding 'OTHER' as a valid registry in lib.harmonization at:
https://github.com/certtools/intelmq/blob/master/intelmq/lib/harmonization.py#L6893

But, yes I agree ingoring that sounds better

@ghost ghost changed the title Cymru-whois bot returning value 'OTHER' for source.registry key Cymru-whois bot returning registry 'OTHER' for 6to4 IPv6 address Jun 6, 2017
@ghost
Copy link

ghost commented Jun 6, 2017

Upstream said that this is intention: As it's an 6to4 address, there's no registry. The same will happen for RFC1918 and private addresses too.

For 6to4 addresses we can do the registry lookup based on the extracted IPv4 address.

@ghost
Copy link

ghost commented Jun 6, 2017

Also note that the network owners for IPv6 and IPv4 are different:

> dig +short 2.8.2.4.e.6.0.d.0.0.0.0.2.8.2.4.e.6.0.d.2.0.0.2.origin6.asn.cymru.com. TXT
"6939 | 2002::/16 |  | other |"
> dig +short 130.66.110.208.origin.asn.cymru.com. TXT
"32097 | 208.110.64.0/19 | US | arin | 2006-03-17"

We could duplicate such events to have both the v4 and the v6 data.

@navtej
Copy link
Contributor

navtej commented Jun 19, 2017

I ran into this today. Pushing a fix.

@ghost ghost closed this as completed in 415285d Jun 26, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

No branches or pull requests

2 participants