Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add external expiry block to event [WEB-496] #4097

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

acdibble
Copy link
Contributor

@acdibble acdibble commented Oct 10, 2023

Pull Request

Closes: WEB-496

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Replaces the old expiry_block

@linear
Copy link

linear bot commented Oct 10, 2023

@acdibble acdibble changed the title feat: add external expiry block to event feat: add external expiry block to event [WEB-496] Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #4097 (c9a824d) into main (2a7e6b2) will decrease coverage by 0%.
Report is 2 commits behind head on main.
The diff coverage is 80%.

@@          Coverage Diff          @@
##            main   #4097   +/-   ##
=====================================
- Coverage     71%     71%   -0%     
=====================================
  Files        377     377           
  Lines      60015   60034   +19     
  Branches   60015   60034   +19     
=====================================
- Hits       42756   42745   -11     
- Misses     15015   15045   +30     
  Partials    2244    2244           
Files Coverage Δ
state-chain/pallets/cf-ingress-egress/src/lib.rs 85% <100%> (+<1%) ⬆️
state-chain/pallets/cf-ingress-egress/src/mock.rs 98% <100%> (ø)
state-chain/pallets/cf-ingress-egress/src/tests.rs 99% <100%> (ø)
state-chain/pallets/cf-lp/src/lib.rs 69% <ø> (ø)
state-chain/traits/src/lib.rs 49% <ø> (ø)
state-chain/traits/src/mocks/deposit_handler.rs 83% <100%> (+1%) ⬆️
state-chain/runtime/src/chainflip.rs 53% <50%> (+1%) ⬆️
state-chain/pallets/cf-swapping/src/lib.rs 84% <82%> (-<1%) ⬇️
api/lib/src/lib.rs 31% <0%> (-<1%) ⬇️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@kylezs kylezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers 👍

@acdibble acdibble merged commit c7e75b7 into main Oct 10, 2023
@acdibble acdibble deleted the feature/web-496 branch October 10, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants