Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use btc rpc client for mempool tracker #4227

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Nov 9, 2023

Diff looks worse than it is, a bit of boilerplate in the tests and what not that may be able to be reduced further. Core logic and interfaces are all the same, so nothing breaking for web guys. Was just type wrangling mostly.

Pull Request

Closes: PRO-909

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works - have tested it running against localnet.
  • I have updated documentation where appropriate.

Summary

Unifies the two btc clients we use so we only use one method of calling a BTC node. We also now share the same types making things more consistent.

Think there's more to do here, but this is a start.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #4227 (b2ef8ff) into main (9f336aa) will decrease coverage by 0%.
Report is 4 commits behind head on main.
The diff coverage is 0%.

@@          Coverage Diff           @@
##            main   #4227    +/-   ##
======================================
- Coverage     72%     71%    -0%     
======================================
  Files        383     383            
  Lines      62350   62834   +484     
  Branches   62350   62834   +484     
======================================
+ Hits       44631   44844   +213     
- Misses     15379   15654   +275     
+ Partials    2340    2336     -4     
Files Coverage Δ
engine/src/dot/retry_rpc.rs 7% <0%> (ø)
engine/src/btc/retry_rpc.rs 9% <0%> (ø)
engine/src/btc/rpc.rs 0% <0%> (ø)

... and 37 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@kylezs kylezs force-pushed the refactor/re-use-btc-rpc-code branch from 3168179 to 471ecb1 Compare November 9, 2023 13:52
Copy link

linear bot commented Nov 9, 2023

PRO-909 BTC part of ingress-egress tracker to use same BTC RPC as witnesser

There's currently a separate BTC RPC that's written for the ingress-egress tracker. We should unify them and use the (base i.e. not the retrier one) RPC client we have for the witnesser (of course, we may need to add some more methods to it.

@kylezs kylezs force-pushed the refactor/re-use-btc-rpc-code branch from 471ecb1 to d41eb66 Compare November 9, 2023 14:02
@kylezs kylezs force-pushed the refactor/re-use-btc-rpc-code branch from d41eb66 to b2ef8ff Compare November 9, 2023 14:08
@kylezs kylezs marked this pull request as ready for review November 9, 2023 15:08
@kylezs kylezs merged commit 95fcd89 into main Nov 14, 2023
@kylezs kylezs deleted the refactor/re-use-btc-rpc-code branch November 14, 2023 07:06
dandanlen pushed a commit that referenced this pull request Nov 17, 2023
refactor: use btc client for mempool tracker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants