fix: don't block unfinalised dot source when can't find events #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylezs
force-pushed
the
fix/dot-chain-tracking-stops-on-no-events
branch
from
67dea9a to
57dd6f8
Compare
engine/src/witness/dot/dot_source.rs
Outdated
| @@ -155,7 +155,8 @@ impl< | |||
| async fn stream_and_client( | |||
| &self, | |||
| ) -> (BoxChainStream<'_, Self::Index, Self::Hash, Self::Data>, Self::Client) { | |||
| polkadot_source!(self, subscribe_finalized_heads, NoRetryLimit, |raw_events| { raw_events }) | |||
| let unwrap_events = |raw_events| raw_events; | |||
There was a problem hiding this comment.
you could dedup this by putting the var inside the macro.
AlastairHolmes
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1010
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Previously in the case of a dot reorg it was possible that the dot source would wait forever to try to get events from a hash that didn't exist, causing dot chain tracking to stop. Now it just makes 2 attempts, and fails out, allowing the chain tracking to continue in such a case.