Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extensible multi-key rotator #4546

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Conversation

RGafiyatullin
Copy link
Contributor

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Provided that we are about to introduce two more foreign-chains, this might be increase ergonomics a tiny bit.

… with ConsKeyRotator (which acts as sort of a linked-list)
@RGafiyatullin RGafiyatullin force-pushed the refactor/cons-key-rotator branch from 7a1be74 to 17f02c1 Compare February 19, 2024 12:58
@RGafiyatullin RGafiyatullin marked this pull request as ready for review February 19, 2024 13:28
Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@dandanlen dandanlen changed the title A multi-KeyRotator that does not require fixed number of underlying KeyRotators feat: extensible multi-key rotator Feb 19, 2024
@dandanlen dandanlen merged commit cf39390 into main Feb 19, 2024
41 of 42 checks passed
@dandanlen dandanlen deleted the refactor/cons-key-rotator branch February 19, 2024 14:15
syan095 added a commit that referenced this pull request Feb 26, 2024
…ero-liquidity

* origin/main: (28 commits)
  feat(custom-rpc): add broker info [WEB-925] (#4560)
  chore: upgrade solana version (#4567)
  fix: continuous adapter (PRO-684) (#4503)
  fix: Wait for ThresholdSignature success before switching to NewKeysActivated (#4534)
  chore: remove un-needed serde derives from EncodedAddress (#4565)
  fix: more lenient max deposit fee in bouncer test (#4564)
  chore: build persa bins instead of fetch (#4554)
  feat: deploy L2 contracts upon localnet startup and send L2 TXs 📑 (#4558)
  feat: debug logs on runtime upgrade test (#4556)
  feature/PRO-1038/pool-fee-rpc (#4459)
  chore: update bootnodes in chainspec ✨ (#4456)
  fix: allow test coverage to run (#4555)
  refactor/pro-1160/remove-side-side-map (#4489)
  fix: activate missing migrations (#4550)
  chore: remove cf-build (#4551)
  feat: extensible multi-key rotator (#4546)
  fix: ensure channel open fee can be paid in benchmarks (#4544)
  feat: bump substrate deps to polkadot-sdk 1.6 (#4504)
  fix: upgrade-test should restart the chainflip-nodes on an incompatible upgrade (#4490)
  test: add small v3 migration test (#4543)
  ...

# Conflicts:
#	state-chain/pallets/cf-pools/src/tests.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants