fix: more robust governance bouncer test #4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4912 +/- ##
=====================================
- Coverage 72% 72% -0%
=====================================
Files 428 428
Lines 73407 73407
Branches 73407 73407
=====================================
- Hits 52641 52640 -1
Misses 18134 18134
- Partials 2632 2633 +1 ☔ View full report in Codecov by Sentry. |
acdibble
reviewed
May 28, 2024
albert-llimos
approved these changes
May 28, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2024
* fix: more robust governance test * chore: lint * fix: simpler tryUntilSuccess * chore: lint
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kylezs
force-pushed
the
fix/robust-gov-test
branch
from
0b425de to
2c63341
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kylezs
added a commit
that referenced
this pull request
May 31, 2024
* fix: more robust governance test * chore: lint * fix: simpler tryUntilSuccess * chore: lint
2 tasks
kylezs
added a commit
that referenced
this pull request
May 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Possible the GovernanceExecuted is actually picking up the executed of another test, and therefore maybe running the check too early. This just protects against that.