Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chain state on bouncer failure #4948

Merged
merged 7 commits into from
Jun 11, 2024
Merged

feat: chain state on bouncer failure #4948

merged 7 commits into from
Jun 11, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Jun 7, 2024

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Prints extrinsics and events to a file after we detect failure of bouncer to better investigate what is going wrong in failures, especially the flaky ones which are hard to reproduce.

I removed the SwapScheduled tracking for the contrat swap, which is just an intermediate step check, isn't checking anything important. I was debugging and can see that the swap is actually scheduled, but for contract swaps, if the swap is executed very quickly, then it's possible the observeEvent code hasn't started until after the SwapScheduled event occurs - meaning the test will hang there forever.

@kylezs kylezs changed the title feat: chain state fail on bouncer failure feat: chain state on bouncer failure Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71%. Comparing base (ef91fdb) to head (7ae8b92).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4948    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        429     429            
  Lines      73980   73836   -144     
  Branches   73980   73836   -144     
======================================
- Hits       52836   52633   -203     
- Misses     18312   18366    +54     
- Partials    2832    2837     +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs force-pushed the feat/chain-state-file branch from b82a687 to cca3493 Compare June 10, 2024 07:58
@kylezs kylezs marked this pull request as ready for review June 10, 2024 08:00
Copy link
Contributor

@ahasna ahasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Uploading the file won't hurt for viewing in a text editor

@kylezs kylezs marked this pull request as draft June 10, 2024 08:11
@kylezs kylezs force-pushed the feat/chain-state-file branch from a378a77 to efbb793 Compare June 10, 2024 09:00
@kylezs kylezs marked this pull request as ready for review June 10, 2024 09:00
@kylezs kylezs enabled auto-merge June 10, 2024 09:25
@kylezs kylezs added this pull request to the merge queue Jun 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 10, 2024
@kylezs kylezs added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 48c0c12 Jun 11, 2024
47 checks passed
@kylezs kylezs deleted the feat/chain-state-file branch June 11, 2024 08:57
kylezs added a commit that referenced this pull request Jun 14, 2024
pick:  contract swaps shouldn't wait for SwapScheduled (#4948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants