-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: chain state on bouncer failure #4948
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4948 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 429 429
Lines 73980 73836 -144
Branches 73980 73836 -144
======================================
- Hits 52836 52633 -203
- Misses 18312 18366 +54
- Partials 2832 2837 +5 ☔ View full report in Codecov by Sentry. |
b82a687
to
cca3493
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Uploading the file won't hurt for viewing in a text editor
a378a77
to
efbb793
Compare
Pull Request
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Prints extrinsics and events to a file after we detect failure of bouncer to better investigate what is going wrong in failures, especially the flaky ones which are hard to reproduce.
I removed the SwapScheduled tracking for the contrat swap, which is just an intermediate step check, isn't checking anything important. I was debugging and can see that the swap is actually scheduled, but for contract swaps, if the swap is executed very quickly, then it's possible the observeEvent code hasn't started until after the SwapScheduled event occurs - meaning the test will hang there forever.