Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the engine dylib file that was preventing it from running on mac localnets.
The dylib install path was previously set to a local path on my machine.
Now it's correctly set to a relative path.
The engine lib build script already do this correctly on main, but that change hasn't been ported to the release branch. Hence the release version 1.4.5 libs were compiled with absolute paths instead of relative paths.
Before:
otool -L old-engine-dylib/libchainflip_engine_v1_4_5.dylib | head -2 old-engine-dylib/libchainflip_engine_v1_4_5.dylib: /Users/dan/[...]/old-engine-dylib/libchainflip_engine_v1_4_5.dylib (compatibility version 0.0.0, current version 0.0.0)
After:
otool -L old-engine-dylib/libchainflip_engine_v1_4_5.dylib | head -2 old-engine-dylib/libchainflip_engine_v1_4_5.dylib: @rpath/old-engine-dylib/libchainflip_engine_v1_4_5.dylib (compatibility version 0.0.0, current version 0.0.0)