Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing Arbitrum block_height #5126

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Fix: Add missing Arbitrum block_height #5126

merged 1 commit into from
Aug 8, 2024

Conversation

marcellorigotti
Copy link
Contributor

Pull Request

Closes: PRO-xxx

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Include arbitrum block_height in the monitoring rpc

Non-Breaking changes

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (1a3cadb) to head (ba917a7).

Files Patch % Lines
state-chain/runtime/src/lib.rs 0% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5126    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        460     460            
  Lines      81649   81507   -142     
  Branches   81649   81507   -142     
======================================
- Hits       58169   57969   -200     
- Misses     20390   20443    +53     
- Partials    3090    3095     +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 8f10dc3 Aug 8, 2024
48 checks passed
@kylezs kylezs deleted the addMissingArb branch August 8, 2024 07:50
syan095 added a commit that referenced this pull request Aug 9, 2024
…tracker

* origin/main:
  Fix: Add missing Arbitrum block_height (#5126)
  chore: update PR template with testing and migration note (#5122)
  feat: Solana chain integration (#4849)

# Conflicts:
#	state-chain/pallets/cf-ingress-egress/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants