Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass isKeySorting to other handler props #531

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Pass isKeySorting to other handler props #531

merged 2 commits into from
Apr 24, 2019

Conversation

b-ryu
Copy link
Contributor

@b-ryu b-ryu commented Apr 23, 2019

Passes isKeySorting to updateBeforeSortStart's SortStart parameter.

Forgot to include this in #501 😅

@clauderic
Copy link
Owner

Good catch! Same with onSortOver actually now that I think of it.

Would you mind also updating the function signature in the docs? 😄

@b-ryu b-ryu force-pushed the keyboard-update-before-sort-start branch from 6d2496f to 9c5fc82 Compare April 23, 2019 21:13
@b-ryu b-ryu changed the title Pass isKeySorting to updateBeforeSortStart Pass isKeySorting to other handler props Apr 23, 2019
Clean up check
4bef0cc 
By the time animateNodes is called, this.newIndex and this.prevIndex should have already been initialized
clauderic
clauderic approved these changes Apr 24, 2019
View reviewed changes
Copy link
Owner

@clauderic clauderic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@clauderic clauderic merged commit 763fd33 into clauderic:master Apr 24, 2019
@clauderic
Copy link
Owner

Released with version 1.9.1

@b-ryu b-ryu deleted the keyboard-update-before-sort-start branch April 24, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauderic clauderic clauderic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-ryu @clauderic