Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run build
is currently broken, for two reasons:browser
was removed from package.json recently (d3b30fd), but it's used in rollup.config.jsminify && uglify
becomesundefined
for the non-minified build, which makesrollup-plugin-commonjs
throw this (at https://github.com/rollup/rollup-plugin-commonjs/blob/v9.3.4/src/resolve-id.js#L50), becauseundefined
isn't a valid plugin:(No idea why this wasn't always happening in the past 🤷♂️)
This PR is a quick fix for both.
umd:main
has the same valuebrowser
used to have, so that's easy, and replacing undefined with{}
makesplugin.resolveId
undefined, which means the plugin gets dropped by rollup, which is really what we want anyway. With this, the build now passes on my machine with a fresh install.