Clear autoscroller when autoscroll is disabled #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauderic
reviewed
Sep 16, 2019
There was a problem hiding this comment.
Hey @superandrew213, good catch, we should definitely clear the autoscroll timeout when autoscroll is disabled.
The only thing I would add to this PR is add a check in the AutoScroller.clear method as to whether this.interval exists here: https://github.com/clauderic/react-sortable-hoc/blob/master/src/AutoScroller/index.js#L7-L10
|
Sure no problem. |
clauderic
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
disableAutoscrollis set totrueby another event while user is dragging, scroll still continues.Must also clear
autoScrollerwhen autoscroll gets disabled.