testing: implement packet parsing from events in MsgSendPacketWithSender #8012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crStiv
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
| var sendResponse channeltypesv2.MsgSendPacketResponse | ||
| err = proto.Unmarshal(msgResponse.Value, &sendResponse) | ||
| if err != nil { | ||
| return channeltypesv2.Packet{}, err |
There was a problem hiding this comment.
This needs to be implemented as a function as is specified in the original issue: #7856
gjermundgaraba
requested changes
Feb 26, 2025
| clientv2types "github.com/cosmos/ibc-go/v10/modules/core/02-client/v2/types" | ||
| channeltypesv2 "github.com/cosmos/ibc-go/v10/modules/core/04-channel/v2/types" | ||
| hostv2 "github.com/cosmos/ibc-go/v10/modules/core/24-host/v2" | ||
| ) | ||
|
|
||
| // ParsePacketFromEventsV2 parses a packet from events using the encoded packet hex attribute. |
There was a problem hiding this comment.
Please take a look at testing/events.go. There is a ParsePacketFromEvents there. This one should be moved there.
| channeltypesv2 "github.com/cosmos/ibc-go/v10/modules/core/04-channel/v2/types" | ||
| ) | ||
|
|
||
| func TestParsePacketFromEventsV2(t *testing.T) { |
There was a problem hiding this comment.
Can you check the tests we have for the previous version of this in testing/events_test.go and make sure we cover the same scenarios. Right off the bat, I see you are not testing what will happen if there are multiple packets in the events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements packet parsing from events in MsgSendPacketWithSender function:
Closes #7856