Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature required: ignore Jupyter notebook cell output #1234

Open
jyang2-q-retail opened this issue Feb 19, 2025 · 1 comment
Open

Feature required: ignore Jupyter notebook cell output #1234

jyang2-q-retail opened this issue Feb 19, 2025 · 1 comment
Labels
A-exclude Area: automatic and user-controlled exclusions C-enhancement Category: Raise on the bar on expectations S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing

Comments

@jyang2-q-retail
Copy link

typos is checking for the cell output, where there could be very random string being return from the function call.

eg. there is a call ID with a langGraph called being printed, and typos would pick this up

error: `Fo` should be `Of`, `For`, `Do`, `Go`, `To`
  --> module-1/2_chain.ipynb:572:29
    |
572 |       " Call ID: call_Er4gChFoSGzU7lsuaGzfSGTQ\n",
    |                             ^^
    |
@epage epage added C-enhancement Category: Raise on the bar on expectations S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing A-exclude Area: automatic and user-controlled exclusions labels Feb 19, 2025
@epage
Copy link
Collaborator

epage commented Feb 19, 2025

Like with #1237, this looks to be a specialized hash that could be detected but I wonder if its specialized enough for

  • Limiting to the jupyter notebook file type
  • Leaving to users to provide through extend-ignore-identifiers-re

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exclude Area: automatic and user-controlled exclusions C-enhancement Category: Raise on the bar on expectations S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing
Projects
None yet
Development

No branches or pull requests

2 participants