Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typ as Typst extension #1253

Open
mo8it opened this issue Mar 6, 2025 · 2 comments
Open

typ as Typst extension #1253

mo8it opened this issue Mar 6, 2025 · 2 comments
Labels
A-dict S-triage Status: New; needs maintainer attention.

Comments

@mo8it
Copy link

mo8it commented Mar 6, 2025

Description

typ -> typo from #1221 (comment) should be reverted since typ is the extension of Typst files.

typ could also be type, so the current state is problematic anyway.

@mo8it mo8it added the S-triage Status: New; needs maintainer attention. label Mar 6, 2025
@epage epage added the A-dict label Mar 6, 2025
@epage
Copy link
Collaborator

epage commented Mar 6, 2025

This opens up a bigger topic, like #1149:

In the past, we accidentally let words be corrected that shouldn't, leading to allowed.csv. Seeing enough english words go through that, we added english.csv.

What I'm wondering is what should be our bar for [file extensions] being included and if we should mass import them. ...

@xxchan
Copy link

xxchan commented Mar 11, 2025

We have massive usage of typ as type :(

e.g.,

error: `typ` should be `typo`
  --> ./src/common/src/row/owned_row.rs:168:13
    |
168 |         for typ in self.data_types() {
    |             ^^^
    |
error: `typ` should be `typo`
  --> ./src/expr/core/src/window_function/kind.rs:48:29
   |
48 |             PbType::General(typ) => match PbGeneralType::try_from(*typ) {
   |                             ^^^
   |
error: `typ` should be `typo`
  --> ./src/tests/sqlsmith/src/sql_gen/expr.rs:40:39
   |
40 |     pub(crate) fn gen_expr(&mut self, typ: &DataType, context: SqlGeneratorContext) -> Expr {
   |                                       ^^^
   |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dict S-triage Status: New; needs maintainer attention.
Projects
None yet
Development

No branches or pull requests

3 participants