Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components API and docs improvements #1103

Merged
merged 18 commits into from
Apr 17, 2024

Conversation

demenech
Copy link
Member

@demenech demenech commented Apr 9, 2024

Related to: #1089

Changes

I tried to make commits very granular so it's easy to figure out what changed based on the commit history.

Copy link

changeset-bot bot commented Apr 9, 2024

🦋 Changeset detected

Latest commit: 48cd812

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@portaljs/components Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@demenech demenech requested a review from olayway April 9, 2024 20:43
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portaljs-alan-turing 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 2:15pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
portaljs-ckan ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 2:15pm
portaljs-ckan-ssg ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 2:15pm
portaljs-fivethirtyeight ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 2:15pm
portaljs-git-example ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 2:15pm
portaljs-learn ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 2:15pm
portaljs-openspending ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 2:15pm
portaljs-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 2:15pm
site-portaljs ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 2:15pm

@rufuspollock
Copy link
Member

@olayway from a quick look this looks great and a good tidy-up. do you want to have a quick look through and if looks ok we can merge.

Copy link
Member

@olayway olayway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olayway olayway merged commit 38dd710 into main Apr 17, 2024
10 checks passed
@olayway
Copy link
Member

olayway commented Apr 17, 2024

Great job @demenech! This is exactly what we needed! Thank you! 🌻

@demenech demenech deleted the feat/portaljs-components-improvements branch April 18, 2024 12:34
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants