Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line Chart improvements #577

Closed
3 tasks done
rufuspollock opened this issue Jul 20, 2021 · 1 comment
Closed
3 tasks done

Line Chart improvements #577

rufuspollock opened this issue Jul 20, 2021 · 1 comment
Assignees
@olayway
Labels
✨ enhancement research

Comments

@rufuspollock
Copy link
Member

rufuspollock commented Jul 20, 2021 •
edited by olayway
Loading

We already have a LineChart component.

LineChart supports

  • loading from url
  • default to temporal type for x axis (?)
  • [ ] uses table schema info if present ... wontfix; if sb needs to pass a full spec then just use VegaLite component directly (LineChart is just a simple wrapper around it with easy to use but very basic interface)
  • auto display all series ... see https://stackoverflow.com/questions/56425430/plot-multiple-columns-with-vega-lite-and-include-a-legend we can't just automatically plot all the columns as they can have incompatible values/types/scales; let's just add support for explicitly plotting multiple series
@rufuspollock rufuspollock transferred this issue from datopian/data-literate Jul 28, 2021
@rufuspollock rufuspollock moved this to 🆕 New in DataHub Oct 31, 2023
@rufuspollock rufuspollock moved this from 🆕 New to 📋 Backlog in DataHub Nov 1, 2023
@olayway olayway moved this from 📋 Backlog to 🏗 In progress in DataHub Aug 29, 2024
@olayway olayway moved this from 🏗 In progress to 🧐 In review in DataHub Aug 29, 2024
@olayway olayway moved this from 🧐 In review to 🏗 In progress in DataHub Aug 29, 2024
@olayway olayway removed their assignment Sep 6, 2024
@olayway olayway moved this from 🏗 In progress to ⏸️ Paused in DataHub Sep 23, 2024
@olayway olayway assigned olayway and unassigned gradedSystem Oct 8, 2024
@olayway olayway mentioned this issue Oct 23, 2024
Merged
@datopian datopian deleted a comment from gradedSystem Oct 23, 2024
@datopian datopian deleted a comment from gradedSystem Oct 23, 2024
@datopian datopian deleted a comment from gradedSystem Oct 23, 2024
@datopian datopian deleted a comment from gradedSystem Oct 23, 2024
@datopian datopian deleted a comment from gradedSystem Oct 23, 2024
@datopian datopian deleted a comment from gradedSystem Oct 23, 2024
@datopian datopian deleted a comment from gradedSystem Oct 23, 2024
@olayway olayway moved this from ⏸️ Paused to 🏗 In progress in DataHub Oct 23, 2024
@olayway
Copy link
Member

olayway commented Oct 23, 2024

FIXED

https://storybook.portaljs.org/?path=/story/components-charts-linechart--multi-series
https://storybook.portaljs.org/?path=/story/components-charts-linechart--multi-columns

@olayway olayway closed this as completed Oct 23, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in DataHub Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olayway olayway

Labels
✨ enhancement research
Projects
DataHub
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rufuspollock @olayway @gradedSystem