Skip to content

Commit 85bfe6c

Browse files
committed
Removes unnecessary module override in tsconfig.client.json.
`tsconfig.json` was updated to use native ESM, so we don't need to override that value anymore. This means the client and prerender use the same configuration and the file could probably be deleted entirely. However I argue that they use the same configuration by coincidence right now and could easily change in the future. Arguably prerender should not include DOM types and client code should not allow JSX. However updating the `tsconfig.json` files to reflect that seems to be more involved. These files will continue to evolve in the future for sure. At some point I need to look into better defined file naming conventions and a solution-style `tsconfig.json`.
1 parent e4642d6 commit 85bfe6c

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

tsconfig.client.json

-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
11
{
22
"extends": "./tsconfig.json",
3-
"compilerOptions": {
4-
// Override module so `tsc` generates JS with ESM `import` instead of CommonJS `require()`.
5-
"module": "ES2020",
6-
}
73
}

0 commit comments

Comments
 (0)