Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geo.region_iso_code #177

Closed
webmat opened this issue Nov 13, 2018 · 7 comments
Closed

Add geo.region_iso_code #177

webmat opened this issue Nov 13, 2018 · 7 comments
Assignees

Comments

@webmat
Copy link
Contributor

webmat commented Nov 13, 2018

The basic GeoIP plugin provides this information when available, we should add it to ECS.

Note that I think there's more to add in the geo field set, but this one is straightforward.

@ruflin
Copy link
Contributor

ruflin commented Nov 14, 2018

Can you open a PR?

@octocat-mona
Copy link

Also country_name is missing, shouldn't all fields from the Geoip Processor be added to the geo object?

@octocat-mona
Copy link

@ruflin Would you accept a PR including all fields from the GeoLite2 City + Country database?
I think the description of the fields are documented here.

@webmat
Copy link
Contributor Author

webmat commented Nov 30, 2018

I already feel like the field names are too tied to Geolite's database naming. I'm not sure we should add 100% of the fields as the canonical names in ECS just yet. Not sure if it's going to come to this eventually, but for now let's add the most canonical names only.

Note that this doesn't prevent you from saving all of the geolite fields in your indices.

@octocat-mona
Copy link

I don't need all of them atm, but it would be nice to have them included at some point or define standardized names which the GeoIP plugin should also use by default.

If country_name could be added at least that would be nice 😉

@webmat
Copy link
Contributor Author

webmat commented Dec 3, 2018

Yes, totally agree. It's on my short list to flesh out geo a bit. I agree we're missing a few pretty basic fields.

Any other that bug you, other than country_name or region_iso_code?

@octocat-mona
Copy link

No, just those would be fine for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants