-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geo.region_iso_code
#177
Comments
Can you open a PR? |
Also |
@ruflin Would you accept a PR including all fields from the GeoLite2 City + Country database? |
I already feel like the field names are too tied to Geolite's database naming. I'm not sure we should add 100% of the fields as the canonical names in ECS just yet. Not sure if it's going to come to this eventually, but for now let's add the most canonical names only. Note that this doesn't prevent you from saving all of the geolite fields in your indices. |
I don't need all of them atm, but it would be nice to have them included at some point or define standardized names which the GeoIP plugin should also use by default. If |
Yes, totally agree. It's on my short list to flesh out geo a bit. I agree we're missing a few pretty basic fields. Any other that bug you, other than |
No, just those would be fine for me 👍 |
The basic GeoIP plugin provides this information when available, we should add it to ECS.
Note that I think there's more to add in the
geo
field set, but this one is straightforward.The text was updated successfully, but these errors were encountered: