Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report FQDN on host.name enabled by a feature flag #2185

Closed
AndersonQ opened this issue Jan 25, 2023 · 2 comments · Fixed by #2218
Closed

Report FQDN on host.name enabled by a feature flag #2185

AndersonQ opened this issue Jan 25, 2023 · 2 comments · Fixed by #2218
Assignees
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team

Comments

@AndersonQ
Copy link
Member

AndersonQ commented Jan 25, 2023

Describe the enhancement:

Following up on elastic/beats#1070, and elastic/ecs#2122 the Elastic Agent should be able to report the FQDN on host.name. This should be configurable by a feature flag on the agent policy.

Describe a specific use case for the enhancement or feature:
There are cases in which different hosts share the same hostname but have different domains. Currently they have the same host.name values, which isn't ideal. Allowing to populate host.name with the FQDN solves that problem. ALso having it behind a feature flag won't make it a breaking change as the user will have the option to enable it or not.

Implementation details

Feature flag generic config:

agent:
  features:
    feature_1:
      enabled:
      config1:
      config2:
      ...
      configN:
    feature_2:
      enabled:
      config1:
      config2:
      ...
      configN:
    ...
    feature_N:
      enabled:
      config1:
      config2:
      ...
      configN:

Feature flag for FQDN:

agent.features.fqdn.enabled: true|false

Related Issues:

@softengchick
Copy link

softengchick commented Feb 7, 2023

@AndersonQ - Endpoint will need to be aware of this feature flag as well. How do you plan on adding it to the configuration. @brian-mckinney - since he is the expert in this area for Endpoint. I see your other PR now!! THANKS!!!

@cmacknz
Copy link
Member

cmacknz commented Feb 7, 2023

The control protocol PR adding the feature flags is elastic/elastic-agent-client#56 I will add Brian as a reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants