From 1285dc3bba9e1e62f4c3fb1ad49301fde889bdb5 Mon Sep 17 00:00:00 2001
From: Simon Ser <contact@emersion.fr>
Date: Tue, 12 Oct 2021 11:42:41 +0200
Subject: [PATCH] server: stop logging TLS handshake errors in ErrorLog

ErrorLog is meant for panic logging only. It should only be used
for logging server implementation bugs, not for logging client
runtime errors.
---
 conn.go   | 1 -
 server.go | 1 -
 2 files changed, 2 deletions(-)

diff --git a/conn.go b/conn.go
index ff497d3..9797efb 100644
--- a/conn.go
+++ b/conn.go
@@ -599,7 +599,6 @@ func (c *Conn) handleStartTLS() {
 	tlsConn := tls.Server(c.conn, c.server.TLSConfig)
 
 	if err := tlsConn.Handshake(); err != nil {
-		c.server.ErrorLog.Printf("TLS handshake error for %s: %v", c.conn.RemoteAddr(), err)
 		c.WriteResponse(550, EnhancedCode{5, 0, 0}, "Handshake error")
 		return
 	}
diff --git a/server.go b/server.go
index 135bfa8..d61020c 100644
--- a/server.go
+++ b/server.go
@@ -146,7 +146,6 @@ func (s *Server) handleConn(c *Conn) error {
 			c.conn.SetWriteDeadline(time.Now().Add(d))
 		}
 		if err := tlsConn.Handshake(); err != nil {
-			s.ErrorLog.Printf("TLS handshake error for %s: %v", tlsConn.RemoteAddr(), err)
 			return err
 		}
 	}