Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Allow to access underlying net.Conn #147

Closed
Tracked by #369
foxcpp opened this issue Jul 16, 2021 · 1 comment · Fixed by #148
Closed
Tracked by #369

server: Allow to access underlying net.Conn #147

foxcpp opened this issue Jul 16, 2021 · 1 comment · Fixed by #148

Comments

@foxcpp
Copy link
Collaborator

foxcpp commented Jul 16, 2021

My use-case is obtaining the full PROXY header from https://github.com/pires/go-proxyproto.

Lazy solution: Just add net.Conn into ConnectionState.
But I feel like getting rid of ConnectionState and just passing Conn to backend is
a better idea. We then can just add Conn.Conn() method (and probably Conn.Hostname()).

@kayrus
Copy link
Contributor

kayrus commented Jul 16, 2021

Do you want to be aware whether PROXY protocol is enabled for a connection?
May be related to #144, where I want to get flexibility for logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants