Increase interoperability with docker-java

[tobiasstadler]

docker-java users registry.* instead docker.* for registry auth config. Provide a fall back to registry.* when docker.* auth config is not found in order to increase interoperability to docker-java

[codecov]

Codecov Report

Merging #1245 into master will decrease coverage by 1.59%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #1245     +/-   ##
===========================================
- Coverage     55.51%   53.92%   -1.6%     
+ Complexity     1760     1638    -122     
===========================================
  Files           156      155      -1     
  Lines          8471     8251    -220     
  Branches       1301     1264     -37     
===========================================
- Hits           4703     4449    -254     
- Misses         3314     3359     +45     
+ Partials        454      443     -11

Impacted Files	Coverage Δ	Complexity Δ
...o/fabric8/maven/docker/util/AuthConfigFactory.java	62.97% <100%> (+8.9%)	64 <7> (+1)	⬆️
.../main/java/io/fabric8/maven/docker/RemoveMojo.java	0% <0%> (-96.73%)	0% <0%> (-33%)
...rc/main/java/io/fabric8/maven/docker/StopMojo.java	0% <0%> (-65.75%)	0% <0%> (-33%)
.../io/fabric8/maven/docker/util/NamePatternUtil.java	84.61% <0%> (-13.57%)	12% <0%> (-16%)
...rc/main/java/io/fabric8/maven/docker/SaveMojo.java	77.02% <0%> (-10.82%)	34% <0%> (-4%)
...va/io/fabric8/maven/docker/AbstractDockerMojo.java	2.94% <0%> (-8.83%)	3% <0%> (-5%)
...aven/docker/model/ImageArchiveManifestAdapter.java	83.33% <0%> (-8.34%)	5% <0%> (-1%)
...io/fabric8/maven/docker/util/ImageArchiveUtil.java	86.95% <0%> (-7.25%)	31% <0%> (-2%)
...abric8/maven/docker/config/ImageConfiguration.java	53.52% <0%> (-6.22%)	15% <0%> (-5%)
...in/java/io/fabric8/maven/docker/util/GavLabel.java	70.58% <0%> (-5.89%)	6% <0%> (-1%)
... and 15 more

[rhuss]

Thanks for the PR ! Could you please help me to understand the use case for this request ? As d-m-p doesn't use docker-java I can't see where docker-java comes into play. Are you using another plugin which uses docker-java internally (which one ?) and you don't want to duplicate the properties ?

[tobiasstadler]

Yes, I am also using Arquillian and Testcontainers in my project (both use docker-java). And it would be nice to set the properties only once.

[rhuss]

Thanks ! I see you use point and I think it doesn't harm. So happy to integrate it.

Could you please fix the comments below and add an entry to the changelog.md ?

[rhuss]

can we please avoid copy & pasting the test ? Just extract a common method which is called once with "docker" and once with "registry" from each individual test.

Helpful would be also a test that ensures that "docker" has precedence over "registry" to keep the default behaviour.

[rhuss]

lgtm