Merge branch 'master' into unvendor-fetch

Author: janicduplessis

.circleci/config.yml

@@ -266,6 +266,7 @@ jobs:
       - run:
           name: Lint code
           command: scripts/circleci/exec_swallow_error.sh yarn lint --format junit -o ~/react-native/reports/junit/eslint/results.xml
+          when: always
 
       - run:
           name: Check for errors in code using Flow (iOS)
@@ -284,6 +285,11 @@ jobs:
             ./scripts/circleci/validate_yarn_lockfile.sh
           when: always
 
+      - run:
+          name: Check formatting
+          command: yarn run format-check
+          when: always
+
       - store_test_results:
           path: ~/react-native/reports/junit
       - store_artifacts:
@@ -299,11 +305,13 @@ jobs:
       - attach_workspace:
           at: ~/react-native
 
-      - run: *run-js-tests
+      - run:
+          name: JavaScript Test Suite
+          command: node ./scripts/run-ci-javascript-tests.js --maxWorkers 2
 
       - run:
           name: JavaScript End-to-End Test Suite
-          command: node ./scripts/run-ci-e2e-tests.js --js --retries 3;
+          command: node ./scripts/run-ci-e2e-tests.js --js --retries 3
 
       - store_test_results:
           path: ~/react-native/reports/junit
@@ -319,9 +327,9 @@ jobs:
 
       - run: *yarn
 
-      - run: *run-js-tests
-
-      - run: yarn run format-check
+      - run:
+          name: JavaScript Test Suite
+          command: node ./scripts/run-ci-javascript-tests.js --maxWorkers 2
 
       - store_test_results:
           path: ~/react-native/reports/junit
@@ -608,7 +616,8 @@ workflows:
       - test_android: *run-after-checkout
       - test_ios: *run-after-checkout
       - test_detox_end_to_end: *run-after-checkout
-      - test_docker_build
+      - test_docker_build:
+          filters: *filter-ignore-gh-pages
 
   releases:
     jobs:

.flowconfig

@@ -103,4 +103,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.96.0
+^0.97.0

.flowconfig.android

@@ -103,4 +103,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.96.0
+^0.97.0

ECOSYSTEM.md

@@ -0,0 +1,58 @@
+# The React Native Ecosystem
+
+We aim to build a vibrant and inclusive ecosystem of partners, core contributors, and community that goes beyond the main React Native GitHub repository. This document explains the roles and responsibilities of various stakeholders and provides guidelines for the community organization. The structure outlined in this document has been in place for a while but hadn't been written down before.
+
+There are three types of stakeholders:
+
+* **Partners:** Companies that are significantly invested in React Native and have been for years.
+* **Core Contributors:** Individual people who contribute to the React Native project.
+* **Community Contributors:** Individuals who support projects in the [react-native-community](https://github.com/react-native-community) organization.
+
+## Partners
+
+Partners are companies that are significantly invested in React Native and have been for years. Informed by their use of React Native, they push for improvements of the core and/or the ecosystem around it. Facebook's partners think of React Native as a product: they understand the trade offs that the project makes as well as future plans and goals. Together we shape the vision for React Native to make it the best way to build applications.
+
+Our current set of partners include Callstack, Expo, Infinite Red, Microsoft and Software Mansion. Many engineers from these companies are core contributors, and their partner responsibilities also include:
+
+* **[Callstack](https://callstack.com/):** Manages releases, maintains the [React Native CLI](https://github.com/react-native-community/react-native-cli) and organizes [React Native EU](https://react-native.eu/)
+* **[Expo](https://expo.io/):** Builds [expo](https://github.com/expo/expo) on top of React Native to simplify app development
+* **[Infinite Red](https://infinite.red/):** Maintains the [ignite cli/boilerplate](https://github.com/infinitered/ignite), organizes [Chain React Conf](https://infinite.red/ChainReactConf)
+* **[Microsoft](https://www.microsoft.com/en-gb/):** Develops [React Native Windows](https://github.com/Microsoft/react-native-windows) for the Universal Windows Platform (UWP)
+* **[Software Mansion](https://swmansion.com/):** Maintain core infrastructure including JSC, Animated, and other popular third-party plugins.
+
+In terms of open source work, pull requests from partners are commonly prioritized. When you are contributing to React Native, you'll most likely meet somebody who works at one of the partner companies and who is a core contributor:
+
+## Core Contributors
+
+Core contributors are individuals who contribute to the React Native project. A core contributor is somebody who displayed a lasting commitment to the evolution and maintenance of React Native. The work done by core contributors includes responsibilities mentioned in the “Partners” section above, and concretely means that they:
+
+* Consistently contribute high quality changes, fixes and improvements
+* Actively review changes and provide quality feedback to contributors
+* Manage the release process of React Native by maintaining release branches, communicating changes to users and publishing releases
+* Love to help out other users with issues on GitHub
+* Mentor and encourage first time contributors
+* Identify React Native community members who could be effective core contributors
+* Help build an inclusive community with people from all backgrounds
+* Are great at communicating with other contributors and the community in general
+
+These are behaviors we have observed in our existing core contributors. They aren't strict rules but rather outline their usual responsibilities. We do not expect every core contributor to do all of the above things all the time. Most importantly, we want to create a supportive and friendly environment that fosters collaboration. Above all else, **we are always polite and friendly.**
+
+Core contributor status is attained after consistently contributing and taking on the responsibilities outlined above and granted by other core contributors. Similarly, after a long period of inactivity, a core contributor may be removed.
+
+We aim to make contributing to React Native as easy and transparent as possible. All important topics are handled through a [discussion or RFC process on GitHub](https://github.com/react-native-community/discussions-and-proposals). We are always looking for active, enthusiastic members of the React Native community to become core contributors.
+
+## Community Contributors
+
+Community contributors are individuals who support projects in the [react-native-community](https://github.com/react-native-community) organization. This organization exists as an incubator for high quality components that extend the capabilities of React Native with functionality that many but not all applications require. Facebook engineers will provide guidance to help build a vibrant community of people and components that make React Native better.
+
+This structure has multiple benefits:
+
+* Keep the core of React Native small, which improves performance and reduces the surface area
+* Provide visibility to projects through shared representation, for example on the React Native website or on Twitter
+* Ensure a consistent and high standard for code, documentation, user experience, stability and contributions for third-party components
+* Upgrade the most important components right away when we make breaking changes and move the ecosystem forward at a fast pace
+* Find new maintainers for projects that are important but were abandoned by previous owners
+
+Additionally, some companies may choose to sponsor the development of one or many of the packages that are part of the community organization. They will commit to maintain projects, triage issues, fix bugs and develop features. In turn, they will be able to gain visibility for their work, for example through a mention of active maintainers in the README of individual projects after a consistent period of contributions. Such a mention may be removed if maintainers abandon the project.
+
+If you are working on a popular component and would like to move it to the React Native community, please create an issue on the [discussions-and-proposals repository](https://github.com/react-native-community/discussions-and-proposals).

Libraries/AppState/AppState.js

@@ -10,7 +10,7 @@
 
 'use strict';
 
-const MissingNativeEventEmitterShim = require('MissingNativeEventEmitterShim');
+const EventEmitter = require('EventEmitter');
 const NativeEventEmitter = require('NativeEventEmitter');
 const NativeModules = require('NativeModules');
 const RCTAppState = NativeModules.AppState;
@@ -27,7 +27,7 @@ const invariant = require('invariant');
 class AppState extends NativeEventEmitter {
   _eventHandlers: Object;
   currentState: ?string;
-  isAvailable: boolean = true;
+  isAvailable: boolean;
 
   constructor() {
     super(RCTAppState);
@@ -114,32 +114,48 @@ class AppState extends NativeEventEmitter {
   }
 }
 
-if (__DEV__ && !RCTAppState) {
-  class MissingNativeAppStateShim extends MissingNativeEventEmitterShim {
-    constructor() {
-      super('RCTAppState', 'AppState');
-    }
+function throwMissingNativeModule() {
+  invariant(
+    false,
+    'Cannot use AppState module when native RCTAppState is not included in the build.\n' +
+      'Either include it, or check AppState.isAvailable before calling any methods.',
+  );
+}
 
-    get currentState(): ?string {
-      this.throwMissingNativeModule();
-    }
+class MissingNativeAppStateShim extends EventEmitter {
+  // AppState
+  isAvailable: boolean = false;
+  currentState: ?string = null;
 
-    addEventListener(...args: Array<any>) {
-      this.throwMissingNativeModule();
-    }
+  addEventListener() {
+    throwMissingNativeModule();
+  }
 
-    removeEventListener(...args: Array<any>) {
-      this.throwMissingNativeModule();
-    }
+  removeEventListener() {
+    throwMissingNativeModule();
   }
 
-  // This module depends on the native `RCTAppState` module. If you don't
-  // include it, `AppState.isAvailable` will return `false`, and any method
-  // calls will throw. We reassign the class variable to keep the autodoc
-  // generator happy.
-  AppState = new MissingNativeAppStateShim();
-} else {
+  // EventEmitter
+  addListener() {
+    throwMissingNativeModule();
+  }
+
+  removeAllListeners() {
+    throwMissingNativeModule();
+  }
+
+  removeSubscription() {
+    throwMissingNativeModule();
+  }
+}
+
+// This module depends on the native `RCTAppState` module. If you don't include it,
+// `AppState.isAvailable` will return `false`, and any method calls will throw.
+// We reassign the class variable to keep the autodoc generator happy.
+if (RCTAppState) {
   AppState = new AppState();
+} else {
+  AppState = new MissingNativeAppStateShim();
 }
 
 module.exports = AppState;

Libraries/Components/ScrollView/ScrollView.js

@@ -368,6 +368,13 @@ export type Props = $ReadOnly<{|
    * ```
    */
   contentContainerStyle?: ?ViewStyleProp,
+  /**
+   * When true, the scroll view stops on the next index (in relation to scroll
+   * position at release) regardless of how fast the gesture is. This can be
+   * used for horizontal pagination when the page is less than the width of
+   * the ScrollView. The default value is false.
+   */
+  disableIntervalMomentum?: ?boolean,
   /**
    * A floating-point number that determines how quickly the scroll view
    * decelerates after the user lifts their finger. You may also use string

Libraries/Components/Touchable/TouchableBounce.js

@@ -184,6 +184,12 @@ const TouchableBounce = ((createReactClass({
         nativeID={this.props.nativeID}
         testID={this.props.testID}
         hitSlop={this.props.hitSlop}
+        clickable={
+          this.props.clickable !== false &&
+          this.props.onPress !== undefined &&
+          !this.props.disabled
+        }
+        onClick={this.touchableHandlePress}
         onStartShouldSetResponder={this.touchableHandleStartShouldSetResponder}
         onResponderTerminationRequest={
           this.touchableHandleResponderTerminationRequest

Libraries/Components/Touchable/TouchableHighlight.js

@@ -422,6 +422,10 @@ const TouchableHighlight = ((createReactClass({
         nextFocusLeft={this.props.nextFocusLeft}
         nextFocusRight={this.props.nextFocusRight}
         nextFocusUp={this.props.nextFocusUp}
+        clickable={
+          this.props.clickable !== false && this.props.onPress !== undefined
+        }
+        onClick={this.touchableHandlePress}
         onStartShouldSetResponder={this.touchableHandleStartShouldSetResponder}
         onResponderTerminationRequest={
           this.touchableHandleResponderTerminationRequest

Libraries/Components/Touchable/TouchableNativeFeedback.android.js

@@ -325,6 +325,11 @@ const TouchableNativeFeedback = createReactClass({
       nextFocusRight: this.props.nextFocusRight,
       nextFocusUp: this.props.nextFocusUp,
       hasTVPreferredFocus: this.props.hasTVPreferredFocus,
+      clickable:
+        this.props.clickable !== false &&
+        this.props.onPress !== undefined &&
+        !this.props.disabled,
+      onClick: this.touchableHandlePress,
       onStartShouldSetResponder: this.touchableHandleStartShouldSetResponder,
       onResponderTerminationRequest: this
         .touchableHandleResponderTerminationRequest,

Libraries/Components/Touchable/TouchableOpacity.js

@@ -324,6 +324,10 @@ const TouchableOpacity = ((createReactClass({
         hasTVPreferredFocus={this.props.hasTVPreferredFocus}
         tvParallaxProperties={this.props.tvParallaxProperties}
         hitSlop={this.props.hitSlop}
+        clickable={
+          this.props.clickable !== false && this.props.onPress !== undefined
+        }
+        onClick={this.touchableHandlePress}
         onStartShouldSetResponder={this.touchableHandleStartShouldSetResponder}
         onResponderTerminationRequest={
           this.touchableHandleResponderTerminationRequest

Libraries/Components/Touchable/TouchableWithoutFeedback.js

@@ -20,20 +20,13 @@ const createReactClass = require('create-react-class');
 const ensurePositiveDelayProps = require('ensurePositiveDelayProps');
 
 const {
-  DeprecatedAccessibilityComponentTypes,
   DeprecatedAccessibilityRoles,
   DeprecatedAccessibilityStates,
-  DeprecatedAccessibilityTraits,
 } = require('DeprecatedViewAccessibility');
 
 import type {SyntheticEvent, LayoutEvent, PressEvent} from 'CoreEventTypes';
 import type {EdgeInsetsProp} from 'EdgeInsetsPropType';
-import type {
-  AccessibilityComponentType,
-  AccessibilityRole,
-  AccessibilityStates,
-  AccessibilityTraits,
-} from 'ViewAccessibility';
+import type {AccessibilityRole, AccessibilityStates} from 'ViewAccessibility';
 
 type TargetEvent = SyntheticEvent<
   $ReadOnly<{|
@@ -47,13 +40,11 @@ type FocusEvent = TargetEvent;
 const PRESS_RETENTION_OFFSET = {top: 20, left: 20, right: 20, bottom: 30};
 
 const OVERRIDE_PROPS = [
-  'accessibilityComponentType',
   'accessibilityLabel',
   'accessibilityHint',
   'accessibilityIgnoresInvertColors',
   'accessibilityRole',
   'accessibilityStates',
-  'accessibilityTraits',
   'hitSlop',
   'nativeID',
   'onBlur',
@@ -64,13 +55,11 @@ const OVERRIDE_PROPS = [
 
 export type Props = $ReadOnly<{|
   accessible?: ?boolean,
-  accessibilityComponentType?: ?AccessibilityComponentType,
   accessibilityLabel?: ?Stringish,
   accessibilityHint?: ?Stringish,
   accessibilityIgnoresInvertColors?: ?boolean,
   accessibilityRole?: ?AccessibilityRole,
   accessibilityStates?: ?AccessibilityStates,
-  accessibilityTraits?: ?AccessibilityTraits,
   children?: ?React.Node,
   delayLongPress?: ?number,
   delayPressIn?: ?number,
@@ -105,18 +94,11 @@ const TouchableWithoutFeedback = ((createReactClass({
     accessible: PropTypes.bool,
     accessibilityLabel: PropTypes.node,
     accessibilityHint: PropTypes.string,
-    accessibilityComponentType: PropTypes.oneOf(
-      DeprecatedAccessibilityComponentTypes,
-    ),
     accessibilityIgnoresInvertColors: PropTypes.bool,
     accessibilityRole: PropTypes.oneOf(DeprecatedAccessibilityRoles),
     accessibilityStates: PropTypes.arrayOf(
       PropTypes.oneOf(DeprecatedAccessibilityStates),
     ),
-    accessibilityTraits: PropTypes.oneOfType([
-      PropTypes.oneOf(DeprecatedAccessibilityTraits),
-      PropTypes.arrayOf(PropTypes.oneOf(DeprecatedAccessibilityTraits)),
-    ]),
     /**
      * When `accessible` is true (which is the default) this may be called when
      * the OS-specific concept of "focus" occurs. Some platforms may not have
@@ -267,6 +249,9 @@ const TouchableWithoutFeedback = ((createReactClass({
     return (React: any).cloneElement(child, {
       ...overrides,
       accessible: this.props.accessible !== false,
+      clickable:
+        this.props.clickable !== false && this.props.onPress !== undefined,
+      onClick: this.touchableHandlePress,
       onStartShouldSetResponder: this.touchableHandleStartShouldSetResponder,
       onResponderTerminationRequest: this
         .touchableHandleResponderTerminationRequest,

Libraries/Components/Touchable/__tests__/__snapshots__/TouchableHighlight-test.js.snap

@@ -3,7 +3,9 @@
 exports[`TouchableHighlight renders correctly 1`] = `
 <View
   accessible={true}
+  clickable={false}
   isTVSelectable={true}
+  onClick={[Function]}
   onResponderGrant={[Function]}
   onResponderMove={[Function]}
   onResponderRelease={[Function]}

Libraries/Components/View/ReactNativeViewAttributes.js

@@ -19,11 +19,9 @@ ReactNativeViewAttributes.UIView = {
   accessible: true,
   accessibilityActions: true,
   accessibilityLabel: true,
-  accessibilityComponentType: true,
   accessibilityLiveRegion: true,
   accessibilityRole: true,
   accessibilityStates: true,
-  accessibilityTraits: true,
   accessibilityHint: true,
   importantForAccessibility: true,
   nativeID: true,