Fix runtime_commit_artifacts workflow

I messed up the yml syntax and also realized that our script doesn't
currently handle renames or deletes, so I fixed that

ghstack-source-id: 7d481a951abaabd1a2985c8959d8acb7103ed12e
Pull Request resolved: #31028

Author: poteto

.github/workflows/runtime_commit_artifacts.yml

@@ -171,7 +171,7 @@ jobs:
 
   commit_www_artifacts:
     needs: download_artifacts
-    if: ${{ (github.ref == 'refs/heads/main' && needs.download_artifacts.outputs.www_branch_count == '0') || github.ref == 'refs/heads/meta-www' }}
+    if: inputs.force == true || (github.ref == 'refs/heads/main' && needs.download_artifacts.outputs.www_branch_count == '0')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -201,7 +201,7 @@ jobs:
           grep -rl "$CURRENT_VERSION_MODERN" ./compiled | xargs -r sed -i -e "s/$CURRENT_VERSION_MODERN/$LAST_VERSION_MODERN/g"
           grep -rl "$CURRENT_VERSION_MODERN" ./compiled || echo "Modern version reverted"
       - name: Check for changes
-        if: !inputs.force
+        if: inputs.force != true
         id: check_should_commit
         run: |
           echo "Full git status"
@@ -219,7 +219,7 @@ jobs:
             echo "should_commit=false" >> "$GITHUB_OUTPUT"
           fi
       - name: Re-apply version changes
-        if: inputs.force || (steps.check_should_commit.outputs.should_commit == 'true' && needs.download_artifacts.outputs.last_version_classic != '' && needs.download_artifacts.outputs.last_version_modern != '')
+        if: inputs.force == true || (steps.check_should_commit.outputs.should_commit == 'true' && needs.download_artifacts.outputs.last_version_classic != '' && needs.download_artifacts.outputs.last_version_modern != '')
         env:
           CURRENT_VERSION_CLASSIC: ${{ needs.download_artifacts.outputs.current_version_classic }}
           CURRENT_VERSION_MODERN: ${{ needs.download_artifacts.outputs.current_version_modern }}
@@ -236,12 +236,12 @@ jobs:
           grep -rl "$LAST_VERSION_MODERN" ./compiled | xargs -r sed -i -e "s/$LAST_VERSION_MODERN/$CURRENT_VERSION_MODERN/g"
           grep -rl "$LAST_VERSION_MODERN" ./compiled || echo "Classic version re-applied"
       - name: Will commit these changes
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
         run: |
           echo ":"
           git status -u
       - name: Commit changes to branch
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
         uses: stefanzweifel/git-auto-commit-action@v4
         with:
           commit_message: |
@@ -255,7 +255,7 @@ jobs:
 
   commit_fbsource_artifacts:
     needs: download_artifacts
-    if: ${{ (github.ref == 'refs/heads/main' && needs.download_artifacts.outputs.fbsource_branch_count == '0') || github.ref == 'refs/heads/meta-fbsource' }}
+    if: inputs.force == true || (github.ref == 'refs/heads/main' && needs.download_artifacts.outputs.fbsource_branch_count == '0')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -278,7 +278,7 @@ jobs:
           grep -rl "$CURRENT_VERSION" ./compiled-rn | xargs -r sed -i -e "s/$CURRENT_VERSION/$LAST_VERSION/g"
           grep -rl "$CURRENT_VERSION" ./compiled-rn || echo "Version reverted"
       - name: Check for changes
-        if: !inputs.force
+        if: inputs.force != 'true'
         id: check_should_commit
         run: |
           echo "Full git status"
@@ -297,7 +297,7 @@ jobs:
             echo "should_commit=false" >> "$GITHUB_OUTPUT"
           fi
       - name: Re-apply version changes
-        if: inputs.force || (steps.check_should_commit.outputs.should_commit == 'true' && needs.download_artifacts.outputs.last_version_rn != '')
+        if: inputs.force == true || (steps.check_should_commit.outputs.should_commit == 'true' && needs.download_artifacts.outputs.last_version_rn != '')
         env:
           CURRENT_VERSION: ${{ needs.download_artifacts.outputs.current_version_rn }}
           LAST_VERSION: ${{ needs.download_artifacts.outputs.last_version_rn }}
@@ -307,12 +307,12 @@ jobs:
           grep -rl "$LAST_VERSION" ./compiled-rn | xargs -r sed -i -e "s/$LAST_VERSION/$CURRENT_VERSION/g"
           grep -rl "$LAST_VERSION" ./compiled-rn || echo "Version re-applied"
       - name: Add files for signing
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
         run: |
           echo ":"
           git add .
       - name: Signing files
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
         uses: actions/github-script@v7
         with:
           script: |
@@ -366,8 +366,9 @@ jobs:
             console.log('Signing files in directory:', directory);
             try {
               const result = execSync(`git status --porcelain ${directory}`, {encoding: 'utf8'});
+              console.log(result);
 
-              // Parse the git status output to get file paths
+              // Parse the git status output to get file paths!
               const files = result.split('\n').filter(file => file.endsWith('.js'));
 
               if (files.length === 0) {
@@ -376,7 +377,14 @@ jobs:
                 );
               } else {
                 files.forEach(line => {
-                  const file = line.slice(3).trim();
+                  let file = null;
+                  if (line.startsWith('D ')) {
+                    return;
+                  } else if (line.startsWith('R ')) {
+                    file = line.slice(line.indexOf('->') + 3);
+                  } else {
+                    file = line.slice(3).trim();
+                  }
                   if (file) {
                     console.log('  Signing file:', file);
                     const originalContents = fs.readFileSync(file, 'utf8');
@@ -395,12 +403,12 @@ jobs:
               console.error('Error signing files:', e);
             }
       - name: Will commit these changes
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
         run: |
           git add .
           git status
       - name: Commit changes to branch
-        if: inputs.force || steps.check_should_commit.outputs.should_commit == 'true'
+        if: inputs.force == true || steps.check_should_commit.outputs.should_commit == 'true'
         uses: stefanzweifel/git-auto-commit-action@v4
         with:
           commit_message: |