Skip to content

Commit 94e652d

Browse files
authored
disable enableSiblingPrerendering in experimental channel (#30952)
Disables `enableSiblingPrerendering` in the experimental builds until the feature is tested at Meta first.
1 parent 4735220 commit 94e652d

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

packages/react-devtools-shared/src/__tests__/TimelineProfiler-test.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ import semver from 'semver';
2121
// TODO: This is how other DevTools tests access the version but we should find
2222
// a better solution for this
2323
const ReactVersionTestingAgainst = process.env.REACT_VERSION || ReactVersion;
24-
const enableSiblingPrerendering = semver.gte(
25-
ReactVersionTestingAgainst,
26-
'19.0.0',
27-
);
24+
// Disabling this while the flag is off in experimental. Leaving the logic so we can
25+
// restore the behavior when we turn the flag back on.
26+
const enableSiblingPrerendering =
27+
false && semver.gte(ReactVersionTestingAgainst, '19.0.0');
2828

2929
describe('Timeline profiler', () => {
3030
let React;

packages/shared/ReactFeatureFlags.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export const enableOwnerStacks = __EXPERIMENTAL__;
148148

149149
export const enableShallowPropDiffing = false;
150150

151-
export const enableSiblingPrerendering = __EXPERIMENTAL__;
151+
export const enableSiblingPrerendering = false;
152152

153153
/**
154154
* Enables an expiration time for retry lanes to avoid starvation.

packages/shared/forks/ReactFeatureFlags.test-renderer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableAddPropertiesFastPath = false;
8080

8181
export const renameElementSymbol = true;
8282
export const enableShallowPropDiffing = false;
83-
export const enableSiblingPrerendering = __EXPERIMENTAL__;
83+
export const enableSiblingPrerendering = false;
8484

8585
// TODO: This must be in sync with the main ReactFeatureFlags file because
8686
// the Test Renderer's value must be the same as the one used by the

0 commit comments

Comments
 (0)