[BE] upgrade prettier to 3.3.3 (#30420)

Mostly just changes in ternary formatting.

Author: kassens

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/hook-noAlias.expect.md

@@ -6,13 +6,9 @@ import {useNoAlias} from 'shared-runtime';
 
 function Component(props) {
   const item = {a: props.a};
-  const x = useNoAlias(
-    item,
-    () => {
-      console.log(props);
-    },
-    [props.a]
-  );
+  const x = useNoAlias(item, () => {
+    console.log(props);
+  }, [props.a]);
   return [x, item];
 }
 

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/hook-noAlias.js

@@ -2,13 +2,9 @@ import {useNoAlias} from 'shared-runtime';
 
 function Component(props) {
   const item = {a: props.a};
-  const x = useNoAlias(
-    item,
-    () => {
-      console.log(props);
-    },
-    [props.a]
-  );
+  const x = useNoAlias(item, () => {
+    console.log(props);
+  }, [props.a]);
   return [x, item];
 }
 

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/preserve-memo-validation/useMemo-constant-prop.expect.md

@@ -11,11 +11,11 @@ function useFoo(cond) {
   const derived1 = useMemo(() => {
     return identity(sourceDep);
   }, [sourceDep]);
-  const derived2 = cond ?? Math.min(sourceDep, 1) ? 1 : 2;
+  const derived2 = (cond ?? Math.min(sourceDep, 1)) ? 1 : 2;
   const derived3 = useMemo(() => {
     return identity(sourceDep);
   }, [sourceDep]);
-  const derived4 = Math.min(sourceDep, -1) ?? cond ? 1 : 2;
+  const derived4 = (Math.min(sourceDep, -1) ?? cond) ? 1 : 2;
   return [derived1, derived2, derived3, derived4];
 }
 

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/preserve-memo-validation/useMemo-constant-prop.ts

@@ -7,11 +7,11 @@ function useFoo(cond) {
   const derived1 = useMemo(() => {
     return identity(sourceDep);
   }, [sourceDep]);
-  const derived2 = cond ?? Math.min(sourceDep, 1) ? 1 : 2;
+  const derived2 = (cond ?? Math.min(sourceDep, 1)) ? 1 : 2;
   const derived3 = useMemo(() => {
     return identity(sourceDep);
   }, [sourceDep]);
-  const derived4 = Math.min(sourceDep, -1) ?? cond ? 1 : 2;
+  const derived4 = (Math.min(sourceDep, -1) ?? cond) ? 1 : 2;
   return [derived1, derived2, derived3, derived4];
 }
 

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/ternary-expression.expect.md

@@ -3,7 +3,7 @@
 
 ```javascript
 function ternary(props) {
-  const a = props.a && props.b ? props.c || props.d : props.e ?? props.f;
+  const a = props.a && props.b ? props.c || props.d : (props.e ?? props.f);
   const b = props.a ? (props.b && props.c ? props.d : props.e) : props.f;
   return a ? b : null;
 }

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/ternary-expression.js

@@ -1,5 +1,5 @@
 function ternary(props) {
-  const a = props.a && props.b ? props.c || props.d : props.e ?? props.f;
+  const a = props.a && props.b ? props.c || props.d : (props.e ?? props.f);
   const b = props.a ? (props.b && props.c ? props.d : props.e) : props.f;
   return a ? b : null;
 }

package.json

@@ -80,7 +80,7 @@
     "minimist": "^1.2.3",
     "mkdirp": "^0.5.1",
     "ncp": "^2.0.0",
-    "prettier": "3.0.3",
+    "prettier": "^3.3.3",
     "prettier-2": "npm:prettier@^2",
     "pretty-format": "^29.4.1",
     "prop-types": "^15.6.2",

packages/react-debug-tools/src/ReactDebugHooks.js

@@ -284,9 +284,9 @@ function useState<S>(
     hook !== null
       ? hook.memoizedState
       : typeof initialState === 'function'
-      ? // $FlowFixMe[incompatible-use]: Flow doesn't like mixed types
-        initialState()
-      : initialState;
+        ? // $FlowFixMe[incompatible-use]: Flow doesn't like mixed types
+          initialState()
+        : initialState;
   hookLog.push({
     displayName: null,
     primitive: 'State',

packages/react-debug-tools/src/__tests__/ReactHooksInspectionIntegration-test.js

@@ -182,14 +182,10 @@ describe('ReactHooksInspectionIntegration', () => {
       React.useLayoutEffect(effect);
       React.useEffect(effect);
 
-      React.useImperativeHandle(
-        outsideRef,
-        () => {
-          // Return a function so that jest treats them as non-equal.
-          return function Instance() {};
-        },
-        [],
-      );
+      React.useImperativeHandle(outsideRef, () => {
+        // Return a function so that jest treats them as non-equal.
+        return function Instance() {};
+      }, []);
 
       React.useMemo(() => state1 + state2, [state1]);
 
@@ -472,14 +468,10 @@ describe('ReactHooksInspectionIntegration', () => {
       React.useLayoutEffect(effect);
       React.useEffect(effect);
 
-      React.useImperativeHandle(
-        outsideRef,
-        () => {
-          // Return a function so that jest treats them as non-equal.
-          return function Instance() {};
-        },
-        [],
-      );
+      React.useImperativeHandle(outsideRef, () => {
+        // Return a function so that jest treats them as non-equal.
+        return function Instance() {};
+      }, []);
 
       React.useMemo(() => state1 + state2, [state1]);
 

packages/react-devtools-shared/src/devtools/views/Settings/ComponentsSettings.js

@@ -349,8 +349,8 @@ export default function ComponentsSettings(_: {}): React.Node {
                     componentFilter.isValid === false
                       ? 'Filter invalid'
                       : componentFilter.isEnabled
-                      ? 'Filter enabled'
-                      : 'Filter disabled'
+                        ? 'Filter enabled'
+                        : 'Filter disabled'
                   }>
                   <ToggleIcon
                     isEnabled={componentFilter.isEnabled}

packages/react-devtools-shared/src/hooks/astUtils.js

@@ -289,7 +289,7 @@ function getHookVariableName(
   const nodeType = hook.node.id.type;
   switch (nodeType) {
     case AST_NODE_TYPES.ARRAY_PATTERN:
-      return !isCustomHook ? hook.node.id.elements[0]?.name ?? null : null;
+      return !isCustomHook ? (hook.node.id.elements[0]?.name ?? null) : null;
 
     case AST_NODE_TYPES.IDENTIFIER:
       return hook.node.id.name;

packages/react-devtools-timeline/src/content-views/ReactMeasuresView.js

@@ -186,8 +186,8 @@ export class ReactMeasuresView extends View {
     context.fillStyle = showHoverHighlight
       ? hoveredFillStyle
       : showGroupHighlight
-      ? groupSelectedFillStyle
-      : fillStyle;
+        ? groupSelectedFillStyle
+        : fillStyle;
     context.fillRect(
       drawableRect.origin.x,
       drawableRect.origin.y,

packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js

@@ -650,9 +650,9 @@ export const scheduleMicrotask: any =
   typeof queueMicrotask === 'function'
     ? queueMicrotask
     : typeof localPromise !== 'undefined'
-    ? callback =>
-        localPromise.resolve(null).then(callback).catch(handleErrorInNextTick)
-    : scheduleTimeout; // TODO: Determine the best fallback here.
+      ? callback =>
+          localPromise.resolve(null).then(callback).catch(handleErrorInNextTick)
+      : scheduleTimeout; // TODO: Determine the best fallback here.
 
 function handleErrorInNextTick(error: any) {
   setTimeout(() => {

packages/react-dom-bindings/src/events/SyntheticEvent.js

@@ -564,23 +564,23 @@ const WheelEventInterface = {
     return 'deltaX' in event
       ? event.deltaX
       : // Fallback to `wheelDeltaX` for Webkit and normalize (right is positive).
-      'wheelDeltaX' in event
-      ? // $FlowFixMe[unsafe-arithmetic] assuming this is a number
-        -event.wheelDeltaX
-      : 0;
+        'wheelDeltaX' in event
+        ? // $FlowFixMe[unsafe-arithmetic] assuming this is a number
+          -event.wheelDeltaX
+        : 0;
   },
   deltaY(event: {[propName: string]: mixed}) {
     return 'deltaY' in event
       ? event.deltaY
       : // Fallback to `wheelDeltaY` for Webkit and normalize (down is positive).
-      'wheelDeltaY' in event
-      ? // $FlowFixMe[unsafe-arithmetic] assuming this is a number
-        -event.wheelDeltaY
-      : // Fallback to `wheelDelta` for IE<9 and normalize (down is positive).
-      'wheelDelta' in event
-      ? // $FlowFixMe[unsafe-arithmetic] assuming this is a number
-        -event.wheelDelta
-      : 0;
+        'wheelDeltaY' in event
+        ? // $FlowFixMe[unsafe-arithmetic] assuming this is a number
+          -event.wheelDeltaY
+        : // Fallback to `wheelDelta` for IE<9 and normalize (down is positive).
+          'wheelDelta' in event
+          ? // $FlowFixMe[unsafe-arithmetic] assuming this is a number
+            -event.wheelDelta
+          : 0;
   },
   deltaZ: 0,
 

packages/react-dom-bindings/src/events/plugins/SelectEventPlugin.js

@@ -80,8 +80,8 @@ function getEventTargetDocument(eventTarget: any) {
   return eventTarget.window === eventTarget
     ? eventTarget.document
     : eventTarget.nodeType === DOCUMENT_NODE
-    ? eventTarget
-    : eventTarget.ownerDocument;
+      ? eventTarget
+      : eventTarget.ownerDocument;
 }
 
 /**

packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js

@@ -515,8 +515,8 @@ export function createRenderState(
           typeof scriptConfig === 'string' || scriptConfig.crossOrigin == null
             ? undefined
             : scriptConfig.crossOrigin === 'use-credentials'
-            ? 'use-credentials'
-            : '';
+              ? 'use-credentials'
+              : '';
       }
 
       preloadBootstrapScriptOrModule(resumableState, renderState, src, props);
@@ -567,8 +567,8 @@ export function createRenderState(
           typeof scriptConfig === 'string' || scriptConfig.crossOrigin == null
             ? undefined
             : scriptConfig.crossOrigin === 'use-credentials'
-            ? 'use-credentials'
-            : '';
+              ? 'use-credentials'
+              : '';
       }
 
       preloadBootstrapScriptOrModule(resumableState, renderState, src, props);
@@ -736,8 +736,8 @@ export function createRootFormatContext(namespaceURI?: string): FormatContext {
     namespaceURI === 'http://www.w3.org/2000/svg'
       ? SVG_MODE
       : namespaceURI === 'http://www.w3.org/1998/Math/MathML'
-      ? MATHML_MODE
-      : ROOT_HTML_MODE;
+        ? MATHML_MODE
+        : ROOT_HTML_MODE;
   return createFormatContext(insertionMode, null, NO_SCOPE);
 }
 
@@ -2493,8 +2493,8 @@ function pushLink(
               props.onLoad && props.onError
                 ? '`onLoad` and `onError` props'
                 : props.onLoad
-                ? '`onLoad` prop'
-                : '`onError` prop';
+                  ? '`onLoad` prop'
+                  : '`onError` prop';
             console.error(
               'React encountered a `<link rel="stylesheet" .../>` with a `precedence` prop and %s. The presence of loading and error handlers indicates an intent to manage the stylesheet loading state from your from your Component code and React will not hoist or deduplicate this stylesheet. If your intent was to have React hoist and deduplciate this stylesheet using the `precedence` prop remove the %s, otherwise remove the `precedence` prop.',
               propDescription,
@@ -2669,8 +2669,8 @@ function pushStyle(
           typeof child === 'function'
             ? 'a Function'
             : typeof child === 'symbol'
-            ? 'a Sybmol'
-            : 'an Array';
+              ? 'a Sybmol'
+              : 'an Array';
         console.error(
           'React expect children of <style> tags to be a string, number, or object with a `toString` method but found %s instead. ' +
             'In browsers style Elements can only have `Text` Nodes as children.',
@@ -3337,8 +3337,8 @@ function pushScriptImpl(
         typeof children === 'number'
           ? 'a number for children'
           : Array.isArray(children)
-          ? 'an array for children'
-          : 'something unexpected for children';
+            ? 'an array for children'
+            : 'something unexpected for children';
       console.error(
         'A script element was rendered with %s. If script element has children it must be a single string.' +
           ' Consider using dangerouslySetInnerHTML or passing a plain string as children.',
@@ -5436,8 +5436,8 @@ function preconnect(href: string, crossOrigin: ?CrossOriginEnum) {
       crossOrigin === 'use-credentials'
         ? 'credentials'
         : typeof crossOrigin === 'string'
-        ? 'anonymous'
-        : 'default';
+          ? 'anonymous'
+          : 'default';
     const key = getResourceKey(href);
     if (!resumableState.connectResources[bucket].hasOwnProperty(key)) {
       resumableState.connectResources[bucket][key] = EXISTS;

packages/react-dom-bindings/src/shared/ReactDOMResourceValidation.js

@@ -68,20 +68,20 @@ export function getValueDescriptorExpectingObjectForWarning(
   return thing === null
     ? '`null`'
     : thing === undefined
-    ? '`undefined`'
-    : thing === ''
-    ? 'an empty string'
-    : `something with type "${typeof thing}"`;
+      ? '`undefined`'
+      : thing === ''
+        ? 'an empty string'
+        : `something with type "${typeof thing}"`;
 }
 
 export function getValueDescriptorExpectingEnumForWarning(thing: any): string {
   return thing === null
     ? '`null`'
     : thing === undefined
-    ? '`undefined`'
-    : thing === ''
-    ? 'an empty string'
-    : typeof thing === 'string'
-    ? JSON.stringify(thing)
-    : `something with type "${typeof thing}"`;
+      ? '`undefined`'
+      : thing === ''
+        ? 'an empty string'
+        : typeof thing === 'string'
+          ? JSON.stringify(thing)
+          : `something with type "${typeof thing}"`;
 }

packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js

@@ -133,8 +133,8 @@ describe('ReactDOMFizzStatic', () => {
     return children.length === 0
       ? undefined
       : children.length === 1
-      ? children[0]
-      : children;
+        ? children[0]
+        : children;
   }
 
   function resolveText(text) {

packages/react-dom/src/__tests__/ReactDOMFizzSuppressHydrationWarning-test.js

@@ -135,8 +135,8 @@ describe('ReactDOMFizzServerHydrationWarning', () => {
     return children.length === 0
       ? undefined
       : children.length === 1
-      ? children[0]
-      : children;
+        ? children[0]
+        : children;
   }
 
   it('suppresses but does not fix text mismatches with suppressHydrationWarning', async () => {

packages/react-dom/src/__tests__/ReactDOMFloat-test.js

@@ -282,8 +282,8 @@ describe('ReactDOMFloat', () => {
     return children.length === 0
       ? undefined
       : children.length === 1
-      ? children[0]
-      : children;
+        ? children[0]
+        : children;
   }
 
   function BlockedOn({value, children}) {

packages/react-dom/src/__tests__/ReactDOMServerSuspense-test.internal.js

@@ -72,8 +72,8 @@ describe('ReactDOMServerSuspense', () => {
     return children.length === 0
       ? undefined
       : children.length === 1
-      ? children[0]
-      : children;
+        ? children[0]
+        : children;
   }
 
   it('should render the children when no promise is thrown', async () => {

packages/react-dom/src/__tests__/ReactDOMSingletonComponents-test.js

@@ -128,8 +128,8 @@ describe('ReactDOM HostSingleton', () => {
     return children.length === 0
       ? undefined
       : children.length === 1
-      ? children[0]
-      : children;
+        ? children[0]
+        : children;
   }
 
   it('warns if you render the same singleton twice at the same time', async () => {